Saved Object Aggregation View #1146

cliu123 · 2022-10-18T00:00:08Z

Description

Enable saved object table to show saved objects across all permitted tenants on a single panel. This is the 1st milestone of the new saved object sharing experience.

Why these changes are required?

The 1st milestone of the new saved object sharing experience.

What is the old behavior before changes and new behavior after changes?

(See the issue)
Current Behavior:
The Saved Object table shows only the saved objects in the selected tenants.
New Behavior:
The Saved Object table shows all the saved objects across all tenants that the logged in user has permissions to.

Issues Resolved

opensearch-project/OpenSearch-Dashboards#2249

Testing

Functional Tests
Existing UTs and ITs

Check List

New functionality includes testing
New functionality has been documented
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Co-authored-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: Yan Zeng <zengyan@amazon.com> Signed-off-by: Chang Liu <lc12251109@gmail.com>

* Add cypress CI for aggregation view Signed-off-by: Ryan Liang <jiallian@amazon.com>

Signed-off-by: Chang Liu <lc12251109@gmail.com>

Signed-off-by: Ryan Liang <jiallian@amazon.com>

codecov-commenter · 2022-10-18T00:02:30Z

Codecov Report

Merging #1146 (4e67d39) into main (7b80f9b) will decrease coverage by 1.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1146      +/-   ##
==========================================
- Coverage   75.08%   73.90%   -1.19%     
==========================================
  Files          86       86              
  Lines        1975     1901      -74     
  Branches      278      251      -27     
==========================================
- Hits         1483     1405      -78     
- Misses        432      439       +7     
+ Partials       60       57       -3

Impacted Files	Coverage Δ
...hboards-plugin/public/apps/account/account-app.tsx	`54.83% <0.00%> (-11.02%)`	⬇️
...n/public/apps/configuration/utils/tenant-utils.tsx	`68.75% <0.00%> (-5.83%)`	⬇️
...plugin/public/apps/account/tenant-switch-panel.tsx	`89.47% <0.00%> (-2.67%)`	⬇️
...-plugin/public/apps/account/account-nav-button.tsx	`71.42% <0.00%> (-2.26%)`	⬇️
...ps/configuration/panels/role-edit/tenant-panel.tsx	`100.00% <0.00%> (ø)`
...ration/panels/role-edit/index-permission-panel.tsx	`93.02% <0.00%> (+2.11%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Chang Liu <lc12251109@gmail.com>

peternied

The 1st milestone

I didn't seen milestones called out in opensearch-project/security#1869, is this Saved Objects Aggregated View the only consideration in scope?

public/apps/account/tenant-switch-panel.tsx

server/auth/types/authentication_type.ts

.github/workflows/cypress-test.yml

DarshitChanpura

Looks good overall! Requested a few changes

public/apps/account/account-app.tsx

public/apps/account/account-nav-button.tsx

opensearch_dashboards.json

public/apps/configuration/panels/role-edit/cluster-permission-panel.tsx

public/apps/configuration/panels/role-edit/index-permission-panel.tsx

public/apps/configuration/panels/role-edit/tenant-panel.tsx

public/plugin.tsx

server/plugin.ts

Signed-off-by: Ryan Liang <jiallian@amazon.com>

public/plugin.tsx

server/saved_objects/saved_objects_wrapper.ts

cliu123 · 2022-10-21T00:15:02Z

The 1st milestone

I didn't seen milestones called out in opensearch-project/security#1869, is this Saved Objects Aggregated View the only consideration in scope?

The PM, UX and Eng are working on figuring out milestones in detail. We have a direction that we are going towards, but the expected UX needs to be fleshed out to provide the following milestones. The issue that this PR is trying to resolve has been linked to the RFC.

opensearch_dashboards.json

public/apps/account/account-app.tsx

public/plugin.tsx

server/auth/types/authentication_type.ts

server/plugin.ts

server/saved_objects/saved_objects_wrapper.ts

Signed-off-by: Chang Liu <lc12251109@gmail.com>

server/saved_objects/saved_objects_wrapper.ts

Co-authored-by: Craig Perkins <cwperx@amazon.com>

Signed-off-by: Chang Liu <lc12251109@gmail.com>

…1157) Signed-off-by: Ryan Liang <jiallian@amazon.com>

server/saved_objects/saved_objects_wrapper.ts

public/apps/configuration/utils/tenant-utils.tsx

server/saved_objects/saved_objects_wrapper.ts

public/apps/account/account-app.tsx

public/apps/account/tenant-switch-panel.tsx

Signed-off-by: Chang Liu <lc12251109@gmail.com>

cliu123 · 2022-10-27T15:12:32Z

@peternied Thanks for reviewing! Sorry, I didn’t mean to re-request your review. I clicked the request review button on all reviewers by mistake.

DarshitChanpura · 2022-10-27T15:44:42Z

.github/workflows/cypress-test.yml

+  FTR_PATH: 'ftr'
+  START_CMD: 'node ../scripts/opensearch_dashboards --dev --no-base-path --no-watch --opensearch_security.multitenancy.enable_aggregation_view=true'
+  OPENSEARCH_SNAPSHOT_CMD: 'node ../scripts/opensearch snapshot'
+  SPEC: 'cypress/integration/plugins/security-dashboards-plugin/aggregation_view.js,'


should this changed to a folder path? Could be done in future if we are planning to add and test more cypress tests.

DarshitChanpura · 2022-10-27T15:45:38Z

public/apps/account/account-app.tsx

+        tenant = await fetchCurrentTenant(coreStart.http);
+      } catch (e) {
+        tenant = undefined;
+        console.log(e);


Do we need this console.log?

(cherry picked from commit 7c8ede6) Signed-off-by: Chang Liu <lc12251109@gmail.com> Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Yan Zeng <zengyan@amazon.com> Co-authored-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Yan Zeng <zengyan@amazon.com> Change version to 2.4 for backport Signed-off-by: Chang Liu <lc12251109@gmail.com>

(cherry picked from commit 7c8ede6) Signed-off-by: Chang Liu <lc12251109@gmail.com> Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Yan Zeng <zengyan@amazon.com> Co-authored-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Yan Zeng <zengyan@amazon.com>

* Saved Object Aggregation View (#1146) * Move tenant-related utils to common folder (#1184) * [Saved Object Aggregation View] Use namespace registry to add tenant filter (#1169) Signed-off-by: Chang Liu <lc12251109@gmail.com> Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: Yan Zeng <zengyan@amazon.com> Co-authored-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com> Co-authored-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Yan Zeng <zengyan@amazon.com>

cliu123 and others added 5 commits October 17, 2022 16:42

Saved Object Aggregation View (#1142)

89a6a57

Co-authored-by: Craig Perkins <cwperx@amazon.com> Co-authored-by: Ryan Liang <jiallian@amazon.com> Co-authored-by: Yan Zeng <zengyan@amazon.com> Signed-off-by: Chang Liu <lc12251109@gmail.com>

[WIP]2.x cypress test ci (#1143)

5757ccf

* Add cypress CI for aggregation view Signed-off-by: Ryan Liang <jiallian@amazon.com>

Add constants and specify types (#1144)

548eefa

Signed-off-by: Chang Liu <lc12251109@gmail.com>

Define variables and functions (#1145)

24d2c12

Signed-off-by: Chang Liu <lc12251109@gmail.com>

change versions to main branch in cypress workflow

f6d4710

Signed-off-by: Ryan Liang <jiallian@amazon.com>

cliu123 requested a review from a team October 18, 2022 00:00

RyanL1997 mentioned this pull request Oct 18, 2022

Add test for aggregation view feature opensearch-project/opensearch-dashboards-functional-test#334

Merged

1 task

Define functions for global and private tenant cases (#1147)

3d1c7ac

Signed-off-by: Chang Liu <lc12251109@gmail.com>

cliu123 requested review from zengyan-amazon and aoguan1990 October 18, 2022 15:51

peternied requested changes Oct 19, 2022

View reviewed changes

public/apps/account/tenant-switch-panel.tsx Outdated Show resolved Hide resolved

server/auth/types/authentication_type.ts Outdated Show resolved Hide resolved

.github/workflows/cypress-test.yml Show resolved Hide resolved

.github/workflows/cypress-test.yml Show resolved Hide resolved

peternied reviewed Oct 19, 2022

View reviewed changes

.github/workflows/cypress-test.yml Outdated Show resolved Hide resolved

DarshitChanpura requested changes Oct 19, 2022

View reviewed changes

change cypress path (#1149)

712db07

Signed-off-by: Ryan Liang <jiallian@amazon.com>

cwperks reviewed Oct 20, 2022

View reviewed changes

public/plugin.tsx Outdated Show resolved Hide resolved

cwperks reviewed Oct 20, 2022

View reviewed changes

public/plugin.tsx Outdated Show resolved Hide resolved

cwperks reviewed Oct 20, 2022

View reviewed changes

server/saved_objects/saved_objects_wrapper.ts Outdated Show resolved Hide resolved

zengyan-amazon reviewed Oct 21, 2022

View reviewed changes

[Feature Branch] Resolve review comments (#1152)

52bb373

Signed-off-by: Chang Liu <lc12251109@gmail.com>

cwperks reviewed Oct 24, 2022

View reviewed changes

server/saved_objects/saved_objects_wrapper.ts Outdated Show resolved Hide resolved

cliu123 and others added 3 commits October 24, 2022 11:38

Use typeToNamespacesMap to resolve Advanced Settings sharing id issue

e204d71

Co-authored-by: Craig Perkins <cwperx@amazon.com>

[Feature Branch] Resolve review comments (#1154)

fa1436c

Signed-off-by: Chang Liu <lc12251109@gmail.com>

[Feature Branch] Resolve review comments (#1155)

2a827da

Signed-off-by: Chang Liu <lc12251109@gmail.com>

cliu123 mentioned this pull request Oct 25, 2022

[Maintenance] Enable CI Workflows to Re-use Setup Steps #1156

Closed

change the cypress functional test reference to functional test repo (#…

54ae31d

…1157) Signed-off-by: Ryan Liang <jiallian@amazon.com>

expani reviewed Oct 26, 2022

View reviewed changes

server/saved_objects/saved_objects_wrapper.ts Outdated Show resolved Hide resolved

expani reviewed Oct 26, 2022

View reviewed changes

public/apps/configuration/utils/tenant-utils.tsx Outdated Show resolved Hide resolved

expani reviewed Oct 26, 2022

View reviewed changes

public/apps/configuration/utils/tenant-utils.tsx Outdated Show resolved Hide resolved

cliu123 commented Oct 26, 2022

View reviewed changes

server/saved_objects/saved_objects_wrapper.ts Outdated Show resolved Hide resolved

cliu123 commented Oct 26, 2022

View reviewed changes

server/saved_objects/saved_objects_wrapper.ts Show resolved Hide resolved

cliu123 commented Oct 26, 2022

View reviewed changes

server/saved_objects/saved_objects_wrapper.ts Outdated Show resolved Hide resolved

zengyan-amazon reviewed Oct 26, 2022

View reviewed changes

public/apps/account/account-app.tsx Show resolved Hide resolved

public/apps/account/tenant-switch-panel.tsx Outdated Show resolved Hide resolved

Resolve review comments (#1159)

4e67d39

Signed-off-by: Chang Liu <lc12251109@gmail.com>

cliu123 dismissed peternied’s stale review via 4e67d39 October 26, 2022 23:56

peternied approved these changes Oct 27, 2022

View reviewed changes

cliu123 added backport 2.x backport to 2.x branch v2.4.0 'Issues and PRs related to version v2.4.0' and removed backport 2.x backport to 2.x branch v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 27, 2022

cliu123 requested review from DarshitChanpura, peternied and RyanL1997 October 27, 2022 15:08

DarshitChanpura approved these changes Oct 27, 2022

View reviewed changes

peternied merged commit 7c8ede6 into main Oct 27, 2022

cliu123 mentioned this pull request Nov 2, 2022

[Saved Object Aggregation View] Use namespace registry to add tenant filter #1169

Merged

3 tasks

cliu123 mentioned this pull request Nov 3, 2022

[Backport 2.x] OSD Saved Object Aggregation View #1186

Merged

cliu123 mentioned this pull request Nov 3, 2022

[Backport 2.4] OSD Saved Object Aggregation View #1187

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Saved Object Aggregation View #1146

Saved Object Aggregation View #1146

cliu123 commented Oct 18, 2022 •

edited

Loading

codecov-commenter commented Oct 18, 2022 •

edited

Loading

peternied left a comment

DarshitChanpura left a comment

cliu123 commented Oct 21, 2022

cliu123 commented Oct 27, 2022 •

edited

Loading

DarshitChanpura Oct 27, 2022 •

edited

Loading

DarshitChanpura Oct 27, 2022

Saved Object Aggregation View #1146

Saved Object Aggregation View #1146

Conversation

cliu123 commented Oct 18, 2022 • edited Loading

Description

Category

Why these changes are required?

What is the old behavior before changes and new behavior after changes?

Issues Resolved

Testing

Check List

codecov-commenter commented Oct 18, 2022 • edited Loading

Codecov Report

peternied left a comment

Choose a reason for hiding this comment

DarshitChanpura left a comment

Choose a reason for hiding this comment

cliu123 commented Oct 21, 2022

cliu123 commented Oct 27, 2022 • edited Loading

DarshitChanpura Oct 27, 2022 • edited Loading

Choose a reason for hiding this comment

DarshitChanpura Oct 27, 2022

Choose a reason for hiding this comment

cliu123 commented Oct 18, 2022 •

edited

Loading

codecov-commenter commented Oct 18, 2022 •

edited

Loading

cliu123 commented Oct 27, 2022 •

edited

Loading

DarshitChanpura Oct 27, 2022 •

edited

Loading