Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 2.0-alpha1 to 2.0-rc1. #946

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Apr 14, 2022

Following opensearch-project/opensearch-build#1863, change 2.0-alpha1 to 2.0-rc1.

@peternied
Copy link
Member

This change is blocked on opensearch-project/security#1764 being added to the distribution build.

@peternied
Copy link
Member

@DarshitChanpura I'm going to be unavaliable for a bit, could you help patch this pull request with update to the build paths? I made this one change without being able to verifiy it, opensearch-project/security@7434ebc

We will need something similar done in this PR

@dblock
Copy link
Member Author

dblock commented Apr 15, 2022

Once there's a successful distribution rc1 build CI will turn green here, let's retry later today.

@codecov-commenter
Copy link

Codecov Report

Merging #946 (e022254) into main (6d6c5b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #946   +/-   ##
=======================================
  Coverage   72.14%   72.14%           
=======================================
  Files          87       87           
  Lines        1906     1906           
  Branches      242      242           
=======================================
  Hits         1375     1375           
  Misses        477      477           
  Partials       54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d6c5b7...e022254. Read the comment docs.

Signed-off-by: dblock <dblock@amazon.com>
peterzhuamazon
peterzhuamazon previously approved these changes Apr 15, 2022
@cliu123
Copy link
Member

cliu123 commented Apr 15, 2022

Signed-off-by: dblock <dblock@amazon.com>
@dblock
Copy link
Member Author

dblock commented Apr 15, 2022

@cliu123
Copy link
Member

cliu123 commented Apr 15, 2022

@DarshitChanpura
Copy link
Member

https://github.com/opensearch-project/security-dashboards-plugin/blob/main/opensearch_dashboards.json#L4

I believe so, updated.

@dblock I see that the version in the main branch is still 2.0.0. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/package.json#L14

Should this be updated? Please let me know if I'm missing something here.

@dblock
Copy link
Member Author

dblock commented Apr 15, 2022

https://github.com/opensearch-project/security-dashboards-plugin/blob/main/opensearch_dashboards.json#L4

I believe so, updated.

@dblock I see that the version in the main branch is still 2.0.0. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/package.json#L14

Should this be updated? Please let me know if I'm missing something here.

Ok, I don't know @kavilla ?

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Apr 15, 2022

https://github.com/opensearch-project/security-dashboards-plugin/blob/main/opensearch_dashboards.json#L4

I believe so, updated.

@dblock I see that the version in the main branch is still 2.0.0. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/package.json#L14

Should this be updated? Please let me know if I'm missing something here.

In Core they just need verion=2.0.0 because they have another version=2.0.0-rc1 passed during build.
To your plugin, you need to point to 2.0.0-rc1 as a whole.

@kavilla let me know if dashboards is like that.
It is a bit different from OS.
So I could be wrong here.

Thanks.

@peterzhuamazon peterzhuamazon merged commit 91d19a6 into opensearch-project:main Apr 15, 2022
@DarshitChanpura
Copy link
Member

DarshitChanpura commented Apr 15, 2022

https://github.com/opensearch-project/security-dashboards-plugin/blob/main/opensearch_dashboards.json#L4

I believe so, updated.

@dblock I see that the version in the main branch is still 2.0.0. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/package.json#L14
Should this be updated? Please let me know if I'm missing something here.

In Core they just need verion=2.0.0 because they have another version=2.0.0-rc1 passed during build. To your plugin, you need to point to 2.0.0-rc1 as a whole. Thanks.

Ah...got it...thank you @peterzhuamazon !

@peterzhuamazon
Copy link
Member

@kavilla let me know if dashboards is like that.
It is a bit different from OS.
So I could be wrong here.

Thanks.

@peterzhuamazon
Copy link
Member

After talking between @kavilla and @dblock we probably need to revert this PR as @kavilla suggest dashboards core still point to 2.0.0 and relies on jenkins to push 2.0.0-rc1.

@dblock dblock deleted the 2.0-rc1 branch April 15, 2022 23:27
@kavilla kavilla mentioned this pull request Apr 15, 2022
3 tasks
@peterzhuamazon
Copy link
Member

Revert in #947

@peternied peternied mentioned this pull request Apr 20, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants