[Build] restore osdVersion to 2.0.0 #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By keeping `opensearchDashboardsVersion: 2.0.0`, plugin owners can do development using the main branch of OpenSearch Dashboards since OpenSearch Dashboards sets this value to 2.0.0. This key-value lets OpenSearch Dashboards can properly install the plugin since it does a semvar + qualifier check on this value if they match then OpenSearch Dashboards proceeds to install it. The build repo passes the qualifier while building OpenSearch Dashboards and plugins that automatically sets this value to build the correct version + qualifier. This allows a distribution to be made with value for `opensearchDashboardsVersion` be the expected value, for example `opensearchDashboardsVersion: 2.0.0-rc1`. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #947 +/- ##
=======================================
Coverage 72.14% 72.14%
=======================================
Files 87 87
Lines 1906 1906
Branches 242 242
=======================================
Hits 1375 1375
Misses 477 477
Partials 54 54 Continue to review full report at Codecov.
|
dblock
approved these changes
Apr 15, 2022
peterzhuamazon
approved these changes
Apr 15, 2022
cliu123
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By keeping
opensearchDashboardsVersion: 2.0.0, plugin owners cando development using the main branch of OpenSearch Dashboards since
OpenSearch Dashboards sets this value to 2.0.0.
This key-value lets OpenSearch Dashboards can properly install the
plugin since it does a semvar + qualifier check on this value if
they match then OpenSearch Dashboards proceeds to install it.
The build repo passes the qualifier while building OpenSearch Dashboards
and plugins that automatically sets this value to build the correct
version + qualifier. This allows a distribution to be made with value
for
opensearchDashboardsVersionbe the expected value, for exampleopensearchDashboardsVersion: 2.0.0-rc1.Original PR:
#946
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Category
[Maintenance]
Why these changes are required?
For local development
What is the old behavior before changes and new behavior after changes?
If using OpenSearch Dashboards
main, the plugin might have issues bootstrapping.Issues Resolved
n/a
Testing
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.