Change blacklist and whitelist nomenclature (#560)

Signed-off-by: Chen Dai <daichen@amazon.com>
opensearch-project · Apr 19, 2022 · 0697354 · 0697354
1 parent 7fdf716
commit 0697354
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/integ-test/src/test/java/org/opensearch/sql/legacy/SQLFunctionsIT.java b/integ-test/src/test/java/org/opensearch/sql/legacy/SQLFunctionsIT.java
@@ -501,7 +501,7 @@ public void concat_ws_field_and_string() throws Exception {
   }
 
   /**
-   * Ignore this test case because painless doesn't whitelist String.split function.
+   * Ignore this test case because painless doesn't allowlist String.split function.
    *
    * @see <a href="https://www.elastic.co/guide/en/elasticsearch/painless/7.0/painless-api-reference.html">https://www.elastic.co/guide/en/elasticsearch/painless/7.0/painless-api-reference.html</a>
    */
@@ -517,7 +517,7 @@ public void whereConditionLeftFunctionRightVariableEqualTest() throws Exception
   }
 
   /**
-   * Ignore this test case because painless doesn't whitelist String.split function.
+   * Ignore this test case because painless doesn't allowlist String.split function.
    *
    * @see <a href="https://www.elastic.co/guide/en/elasticsearch/painless/7.0/painless-api-reference.html">https://www.elastic.co/guide/en/elasticsearch/painless/7.0/painless-api-reference.html</a>
    */
@@ -810,7 +810,7 @@ public void isnullWithMathExpr() throws IOException {
   }
 
   /**
-   * Ignore this test case because painless doesn't whitelist String.split function.
+   * Ignore this test case because painless doesn't allowlist String.split function.
    *
    * @see <a href="https://www.elastic.co/guide/en/elasticsearch/painless/7.0/painless-api-reference.html">https://www.elastic.co/guide/en/elasticsearch/painless/7.0/painless-api-reference.html</a>
    */

diff --git a/legacy/src/main/java/org/opensearch/sql/legacy/utils/SQLFunctions.java b/legacy/src/main/java/org/opensearch/sql/legacy/utils/SQLFunctions.java
@@ -136,7 +136,7 @@ public Tuple<String, String> function(String methodName, List<KVValue> paramers,
                 break;
             }
 
-            // Split is currently not supported since its using .split() in painless which is not whitelisted
+            // Split is currently not supported since its using .split() in painless which is not allow-listed
             case "split":
                 if (paramers.size() == 3) {
                     functionStr = split((SQLExpr) paramers.get(0).value,

diff --git a/legacy/src/test/java/org/opensearch/sql/legacy/antlr/SyntaxAnalysisTest.java b/legacy/src/test/java/org/opensearch/sql/legacy/antlr/SyntaxAnalysisTest.java
@@ -17,7 +17,7 @@
 import org.opensearch.sql.legacy.antlr.syntax.SyntaxAnalysisException;
 
 /**
- * Test cases focused on illegal syntax testing (blacklist) along with a few normal cases not covered previously.
+ * Test cases focused on illegal syntax testing (denylist) along with a few normal cases not covered previously.
  * All other normal cases should be covered in existing unit test and IT.
  */
 public class SyntaxAnalysisTest {