Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change blacklist and whitelist nomenclature #560

Conversation

dai-chen
Copy link
Collaborator

Signed-off-by: Chen Dai daichen@amazon.com

Description

Change blacklist and whitelist nomenclature: from blacklist and whitelist to denylist and allowlist.

Issues Resolved

#464

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen self-assigned this Apr 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #560 (c0af10a) into main (c8b58da) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #560   +/-   ##
=========================================
  Coverage     94.59%   94.59%           
  Complexity     2742     2742           
=========================================
  Files           276      276           
  Lines          7454     7454           
  Branches        550      550           
=========================================
  Hits           7051     7051           
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b58da...c0af10a. Read the comment docs.

@dai-chen dai-chen marked this pull request as ready for review April 14, 2022 22:11
@dai-chen dai-chen requested a review from a team as a code owner April 14, 2022 22:11
@dai-chen dai-chen merged commit b56cd4c into opensearch-project:main Apr 14, 2022
@dai-chen dai-chen deleted the change-blacklist-whitelist-nomenclature branch April 14, 2022 23:53
vamsi-amazon pushed a commit that referenced this pull request Apr 19, 2022
Signed-off-by: Chen Dai <daichen@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants