Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-38414: Revert #1988 "Graduate UserDefinedNetworks to GA" #1996

Merged

Conversation

stbenjam
Copy link
Member

Reverts #1988 ; tracked by OCPBUGS-38414

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

UDN tests are permafailing on metal

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Test metal with the new UDN tests

CC: @tssurya

PR created by Revertomatic™️

…o-ga"

This reverts commit b300703, reversing
changes made to d6942fb.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 13, 2024
Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

Hello @stbenjam! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot
Copy link

@stbenjam: This pull request references Jira Issue OCPBUGS-38414, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #1988 ; tracked by OCPBUGS-38414

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

UDN tests are permafailing on metal

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Test metal with the new UDN tests

CC: @tssurya

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 13, 2024
@stbenjam stbenjam changed the title OCPBUGS-38414: Revert #1988 "SDN-4919,SDN-5135: Graduate UserDefinedNetworks to GA" OCPBUGS-38414: Revert #1988 "Graduate UserDefinedNetworks to GA" Aug 13, 2024
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 13, 2024
@openshift-ci openshift-ci bot requested review from knobunc and soltysh August 13, 2024 11:30
@stbenjam
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 13, 2024
@openshift-ci-robot
Copy link

@stbenjam: This pull request references Jira Issue OCPBUGS-38414, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Contributor

/lgtm

@stbenjam
Copy link
Member Author

We're returning to a known state (the feature gate off)

/label approved
/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-serial-techpreview
/override ci/prow/e2e-aws-ovn-techpreview
/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/e2e-upgrade-minor
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-azure
/override ci/prow/e2e-aws-serial

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2024
Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member Author

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-hypershift

Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-hypershift

In response to this:

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit e48b223 into openshift:master Aug 13, 2024
18 checks passed
@openshift-ci-robot
Copy link

@stbenjam: Jira Issue OCPBUGS-38414: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38414 has been moved to the MODIFIED state.

In response to this:

Reverts #1988 ; tracked by OCPBUGS-38414

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

UDN tests are permafailing on metal

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Test metal with the new UDN tests

CC: @tssurya

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408132015.p0.ge48b223.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment