Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDN-4919: Revert "OCPBUGS-38414: Revert #1988 "Graduate UserDefinedNetworks to GA"" #1997

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented Aug 13, 2024

Reverts #1996
openshift/origin#28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe.

@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature? (update: QE has run all tests on all platforms)

The bug was in the e2e anyways not in the feature when revert happened. Also we wouldn't have caught it until we GA-ed it. So let's try this again.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 13, 2024

@tssurya: This pull request references SDN-4919 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to this:

Reverts #1996
openshift/origin#28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe

@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 13, 2024
Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

Hello @tssurya! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 13, 2024
@tssurya
Copy link
Contributor Author

tssurya commented Aug 13, 2024

/payload 4.18 ci blocking
/payload 4.18 nightly blocking

Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

@tssurya: trigger 4 job(s) of type blocking for the ci release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cef7fd70-5971-11ef-8e9c-fd73856402bf-0

trigger 10 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cef7fd70-5971-11ef-8e9c-fd73856402bf-1

@tssurya
Copy link
Contributor Author

tssurya commented Aug 13, 2024

/payload cancel

Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

@tssurya: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@tssurya
Copy link
Contributor Author

tssurya commented Aug 13, 2024

/payload-abort

Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

@tssurya: aborted active payload jobs for pull request #1997

Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

@smg247: This PR was included in a payload test run from openshift/origin#28997
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/502783a0-5974-11ef-88ea-51e3322bf150-0

Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

@smg247: This PR was included in a payload test run from openshift/origin#28997
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c93b2670-5974-11ef-94b4-ebabd8a793eb-0

@tssurya
Copy link
Contributor Author

tssurya commented Aug 14, 2024

/payload 4.18 ci blocking
/payload 4.18 nightly blocking

Copy link
Contributor

openshift-ci bot commented Aug 14, 2024

@tssurya: trigger 4 job(s) of type blocking for the ci release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ebfdfce0-59f7-11ef-922d-84ad5312de64-0

trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ebfdfce0-59f7-11ef-922d-84ad5312de64-1

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 14, 2024

@tssurya: This pull request references SDN-4919 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to this:

Reverts #1996
openshift/origin#28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe.

@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature? (update: QE has run all tests on all platforms)

The bug was in the e2e anyways not in the feature when revert happened. Also we wouldn't have caught it until we GA-ed it. So let's try this again.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anuragthehatter
Copy link

/lgtm
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 14, 2024

@tssurya: This pull request references SDN-4919 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to this:

Reverts #1996
openshift/origin#28997 has merged, I was on PTO and woke up to the revert, we already had the metal e2e fix in the pipe.

@huiran0826 @anuragthehatter : can you please check if metal jobs were run for the UDN feature? (update: QE has run all tests on all platforms)

The bug was in the e2e anyways not in the feature when revert happened. Also we wouldn't have caught it until we GA-ed it. So let's try this again.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2024
Copy link
Contributor

openshift-ci bot commented Aug 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anuragthehatter, tssurya
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tssurya
Copy link
Contributor Author

tssurya commented Aug 14, 2024

/retest-required

Copy link
Contributor

openshift-ci bot commented Aug 14, 2024

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259
trigger 4 job(s) of type blocking for the ci release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d5e52620-5a76-11ef-8cf6-cba82feaebc3-0

Copy link
Contributor

openshift-ci bot commented Aug 14, 2024

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259
trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea0bb010-5a76-11ef-8170-4812ecdc1d87-0

@tssurya
Copy link
Contributor Author

tssurya commented Aug 14, 2024

/retest-required

@tssurya
Copy link
Contributor Author

tssurya commented Aug 15, 2024

/retest-required

@tssurya
Copy link
Contributor Author

tssurya commented Aug 15, 2024

/payload 4.18 ci blocking
/payload 4.18 nightly blocking

Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

@tssurya: trigger 4 job(s) of type blocking for the ci release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9cae2d30-5aac-11ef-92b9-f2c993677c34-0

trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9cae2d30-5aac-11ef-92b9-f2c993677c34-1

Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259
trigger 4 job(s) of type blocking for the ci release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8d2ebc20-5ab7-11ef-8555-1c089b208de9-0

Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1de333d0-5abe-11ef-983f-862ee23e83ff-0

Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259
trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3cb7f6b0-5abe-11ef-9387-ff294f89ad91-0

Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

@ormergi: This PR was included in a payload test run from openshift/origin#28995
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/09943ab0-5b08-11ef-9839-571e36a6895a-0

Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

@ormergi: This PR was included in a payload test run from openshift/origin#28995
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5fb66670-5b08-11ef-9ac7-70a30b4950ee-0

@tssurya
Copy link
Contributor Author

tssurya commented Aug 15, 2024

/hold
we will hold merging this for now because @JoelSpeed showed another workaround that @trozet showed me which is to have lanes run as presubmits with UDN enabled which I didn't know we could do!
that will help us get the signal we need.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2024
Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259
trigger 4 job(s) of type blocking for the ci release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a9f97d80-5bd0-11ef-9106-821b4d285fa7-0

Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

@tssurya: This PR was included in a payload test run from openshift/ovn-kubernetes#2259
trigger 9 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b2636bc0-5bd0-11ef-8f6b-ff174841c8a0-0

@stbenjam
Copy link
Member

/test verify

Just checking if metal shows up

@stbenjam
Copy link
Member

/test verify

Copy link
Contributor

openshift-ci bot commented Aug 18, 2024

@ormergi: This PR was included in a payload test run from openshift/origin#28995
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d1d45330-5d73-11ef-9a7f-e73dabc2a915-0

Copy link
Contributor

openshift-ci bot commented Aug 18, 2024

@ormergi: This PR was included in a payload test run from openshift/origin#28995
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e0c7afe0-5d73-11ef-835c-f127b811b5d4-0

@tssurya
Copy link
Contributor Author

tssurya commented Aug 19, 2024

@stbenjam yeah the metal is showing up.. looks like we need more runs on that :D

@tssurya
Copy link
Contributor Author

tssurya commented Aug 19, 2024

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn 10

Copy link
Contributor

openshift-ci bot commented Aug 19, 2024

@tssurya: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3fa07720-5e20-11ef-9a73-769c3cdb2a25-0

@stbenjam
Copy link
Member

/test verify

@stbenjam
Copy link
Member

payload-aggregate periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn 10

Are you trying to get more signal for the verify job? These won't contribute to it, since it's from a PR. It only considers signal from merged PR's. I can kick off a couple jobs if you need it.

@stbenjam
Copy link
Member

/test verify

@tssurya
Copy link
Contributor Author

tssurya commented Aug 20, 2024

payload-aggregate periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn 10

Are you trying to get more signal for the verify job? These won't contribute to it, since it's from a PR. It only considers signal from merged PR's. I can kick off a couple jobs if you need it.

yeah how do I trigger techpreview vsphere jobs? I couldn't get the right job name :(

@stbenjam
Copy link
Member

/test verify

1 similar comment
@stbenjam
Copy link
Member

/test verify

Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

@tssurya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-minor 733cabf link true /test e2e-upgrade-minor
ci/prow/verify 733cabf link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stbenjam
Copy link
Member

Only one test remaining that's not at the threshold - I kicked off 10x metal jobs to boost signal, should hopefully know in a few hours

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants