Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: USHIFT-3480: fips failing with golang-1.22 #3476

Closed
wants to merge 1 commit into from

Conversation

eslutsky
Copy link
Contributor

Which issue(s) this PR addresses:

Closes #

Signed-off-by: Evgeny Slutsky <eslutsky@eslutsky-thinkpadp16vgen1.raanaii.csb>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 12, 2024

@eslutsky: This pull request references USHIFT-3480 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 12, 2024
@openshift-ci openshift-ci bot requested review from copejon and pmtk June 12, 2024 13:19
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024
@eslutsky
Copy link
Contributor Author

/test metal-periodic-test

@pacevedom
Copy link
Contributor

Can you add some context as to why the new image works?

@eslutsky
Copy link
Contributor Author

/hold
this doesnt fix the original problem

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2024
@eslutsky eslutsky changed the title USHIFT-3480: fips failing with golang-1.22 WIP: USHIFT-3480: fips failing with golang-1.22 Jun 13, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2024
@ggiguash
Copy link
Contributor

/test metal-periodic-test

2 similar comments
@ggiguash
Copy link
Contributor

/test metal-periodic-test

@ggiguash
Copy link
Contributor

/test metal-periodic-test

Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

@eslutsky: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/metal-periodic-test cfe37f1 link true /test metal-periodic-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eslutsky
Copy link
Contributor Author

/close
closing in favor of #3505 .

@openshift-ci openshift-ci bot closed this Jun 19, 2024
Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

@eslutsky: Closed this PR.

In response to this:

/close
closing in favor of #3505 .

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants