Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-3480: exclude fips tests from 4.17 #3505

Merged
merged 1 commit into from
Jun 20, 2024
Merged

USHIFT-3480: exclude fips tests from 4.17 #3505

merged 1 commit into from
Jun 20, 2024

Conversation

eslutsky
Copy link
Contributor

fips check-payload missing golang-1.22 symobls in 4.17 , temporarily disabling fips tests from periodics.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 18, 2024 •
edited by openshift-ci bot
Loading

@eslutsky: This pull request references USHIFT-3480 which is a valid jira issue.

In response to this:

fips check-payload missing golang-1.22 symobls in 4.17 , temporarily disabling fips tests from periodics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor

@eslutsky , can be rename the files to .disabled instead of deleting them?

@copejon copejon mentioned this pull request Jun 18, 2024
Merged
@openshift-ci openshift-ci bot requested review from ggiguash and pmtk June 18, 2024 13:49
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
USHIFT-3480: exclude fips tests from 4.17 periodics
045b940 
Signed-off-by: Evgeny Slutsky <eslutsky@dhcp-1-214.lcy.redhat.com>
@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dbe80c3 and 2 for PR HEAD 045b940 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e9533cf and 1 for PR HEAD 045b940 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2cf0fbd and 0 for PR HEAD 045b940 in total

@eslutsky
Copy link
Contributor Author

/test metal-periodic-test

@openshift-ci-robot
Copy link

/hold

Revision 045b940 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2024
@eslutsky
Copy link
Contributor Author

test is failing because of aws infra capacity issue.

@eslutsky eslutsky mentioned this pull request Jun 19, 2024
Closed
@eslutsky
Copy link
Contributor Author

/test metal-periodic-test

1 similar comment
@ggiguash
Copy link
Contributor

/test metal-periodic-test

@eslutsky
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

@eslutsky: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e7c4134 into openshift:main Jun 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggiguash ggiguash Awaiting requested review from ggiguash

@pmtk pmtk Awaiting requested review from pmtk

Assignees

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eslutsky @openshift-ci-robot @ggiguash