Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fix ValueError when plotting events components #1368

Conversation

johnnykwan21
Copy link

🔬 Background

Fixed ValueError when plotting events components using plot_parameters method inside forecaster.py, see #1366

🔮 Key changes

Simple fixing check_if_configured & get_valid_configuration function inside plot_utils.py

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #1368 (b1dddb1) into main (50d5e41) will increase coverage by 0.00%.
The diff coverage is 81.48%.

@@           Coverage Diff           @@
##             main    #1368   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          38       38           
  Lines        5084     5086    +2     
=======================================
+ Hits         4568     4570    +2     
  Misses        516      516           
Files Coverage Δ
neuralprophet/plot_utils.py 88.05% <81.48%> (+0.08%) ⬆️

Copy link
Collaborator

@leoniewgnr leoniewgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, looks really good! Thanks for fixing it! Would you mind adding a test to it, so that the code coverage is fulfilled and we won't run into that problem again?

@leoniewgnr leoniewgnr added the status: in development Pull requests which are in development label Jul 8, 2023
@SimonWittner
Copy link
Collaborator

Closed with #1434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in development Pull requests which are in development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants