Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Pytest for fix ValueError when plotting events components #1434

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

SimonWittner
Copy link
Collaborator

🔬 Background

Fixed ValueError when plotting events components using plot_parameters method inside forecaster.py, see #1366

🔮 Key changes

Simple fixing check_if_configured & get_valid_configuration function inside plot_utils.py
Added pytests for fix

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

@SimonWittner SimonWittner added the status: needs review PR needs to be reviewed by Reviewer(s) label Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1434 (ad45b49) into main (50d5e41) will increase coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is 90.62%.

@@            Coverage Diff             @@
##             main    #1434      +/-   ##
==========================================
+ Coverage   89.85%   89.89%   +0.04%     
==========================================
  Files          38       38              
  Lines        5084     5088       +4     
==========================================
+ Hits         4568     4574       +6     
+ Misses        516      514       -2     
Files Coverage Δ
neuralprophet/forecaster.py 87.40% <ø> (ø)
neuralprophet/utils.py 79.66% <100.00%> (+0.11%) ⬆️
neuralprophet/plot_utils.py 88.80% <88.88%> (+0.83%) ⬆️

Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@SimonWittner SimonWittner merged commit c24f42a into ourownstory:main Oct 2, 2023
10 of 13 checks passed
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.34899 1.34899 0.0%
YosemiteTemps RMSE_val 2.00817 2.00817 0.0%
YosemiteTemps Loss_val 0.00078 0.00078 0.0%
YosemiteTemps MAE 1.32133 1.32133 0.0%
YosemiteTemps RMSE 2.13713 2.13713 0.0%
YosemiteTemps Loss 0.00064 0.00064 0.0%
YosemiteTemps time 70.0035 58.36 -16.63% 🎉
PeytonManning MAE_val 0.58162 0.58162 0.0%
PeytonManning RMSE_val 0.72218 0.72218 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 14.2688 12.88 -9.73% 🎉
AirPassengers MAE_val 13.0627 13.0627 0.0%
AirPassengers RMSE_val 15.9453 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88153 9.88153 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 5.60932 5.28 -5.87% 🎉
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants