Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrub all changes to Protobuf files since last release to verify that they have "Added in 1.4.0" comment for new fields. #487

Closed
jafingerhut opened this issue Jul 4, 2024 · 1 comment
Closed

Scrub all changes to Protobuf files since last release to verify that they have "Added in 1.4.0" comment for new fields. #487

jafingerhut opened this issue Jul 4, 2024 · 1 comment
Labels
1.4.0 Issues and PRs that we want to go into 1.4.0

Comments

@jafingerhut
Copy link
Contributor

jafingerhut commented Jul 4, 2024 •
edited
Loading

For example, this PR appears not to have such comments on new fields that it added: fee499a

It would be good to do something like this and go through every change to the .proto files since the last release to verify whether all new fields are marked as new in 1.4.0, if they are.

git clone https://github.com/p4lang/p4runtime
cd p4runtime
git diff v1.3.0 HEAD proto
@jafingerhut jafingerhut added the 1.4.0 Issues and PRs that we want to go into 1.4.0 label Jul 4, 2024
chrispsommers added a commit that referenced this issue Aug 6, 2024
@chrispsommers
Add v1.4.0 comments to protobufs - fix #487 (#490)
f0123f7 
* Added missing "Added/deprecated in v1.4.0" comments per convention.

* Added missing "Added/deprecated in v1.4.0" comments per convention.

* Refresh generated go files.
@chrispsommers
Copy link
Collaborator

Merged into version-1.4.0-rc #490
Intended to be merged into main

chrispsommers added a commit to chrispsommers/p4runtime that referenced this issue Sep 4, 2024
@chrispsommers
Add v1.4.0 comments to protobufs - fix p4lang#487 (p4lang#490)
afdd0b9 
* Added missing "Added/deprecated in v1.4.0" comments per convention.

* Added missing "Added/deprecated in v1.4.0" comments per convention.

* Refresh generated go files.
chrispsommers added a commit to chrispsommers/p4runtime that referenced this issue Sep 4, 2024
@chrispsommers
Add v1.4.0 comments to protobufs - fix p4lang#487 (p4lang#490)
32a2582 
* Added missing "Added/deprecated in v1.4.0" comments per convention.

* Added missing "Added/deprecated in v1.4.0" comments per convention.

* Refresh generated go files.

Signed-off-by: chris <chris.sommers@keysight.com>
chrispsommers added a commit to chrispsommers/p4runtime that referenced this issue Sep 16, 2024
@chrispsommers
Add v1.4.0 comments to protobufs - fix p4lang#487 (p4lang#490)
0cf3e11 
* Added missing "Added/deprecated in v1.4.0" comments per convention.

* Added missing "Added/deprecated in v1.4.0" comments per convention.

* Refresh generated go files.

Signed-off-by: chris <chris.sommers@keysight.com>
chrispsommers added a commit that referenced this issue Sep 16, 2024
@chrispsommers @smolkaj
Version 1.4.0 rc updates to bazel and protobuf comments (#499)
dda9d66 
* Add v1.4.0 comments to protobufs - fix #487 (#490)

* Added missing "Added/deprecated in v1.4.0" comments per convention.

* Added missing "Added/deprecated in v1.4.0" comments per convention.

* Refresh generated go files.

Signed-off-by: chris <chris.sommers@keysight.com>

* Update Bazel example to point to 1.4.0 (#493)

Signed-off-by: Steffen Smolka <smolkaj@google.com>
Signed-off-by: chris <chris.sommers@keysight.com>

* Regenerate rust code.

Signed-off-by: chris <chris.sommers@keysight.com>

---------

Signed-off-by: chris <chris.sommers@keysight.com>
Signed-off-by: Steffen Smolka <smolkaj@google.com>
Co-authored-by: Steffen Smolka <smolkaj@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.4.0 Issues and PRs that we want to go into 1.4.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jafingerhut @chrispsommers