Add v1.4.0 comments to protobufs - fix https://github.com/p4lang/p4runtime/issues/487 #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafingerhut
approved these changes
Aug 6, 2024
This was referenced Aug 6, 2024
chrispsommers
added a commit
to chrispsommers/p4runtime
that referenced
this pull request
Sep 4, 2024
* Added missing "Added/deprecated in v1.4.0" comments per convention. * Added missing "Added/deprecated in v1.4.0" comments per convention. * Refresh generated go files.
chrispsommers
added a commit
to chrispsommers/p4runtime
that referenced
this pull request
Sep 4, 2024
* Added missing "Added/deprecated in v1.4.0" comments per convention. * Added missing "Added/deprecated in v1.4.0" comments per convention. * Refresh generated go files. Signed-off-by: chris <chris.sommers@keysight.com>
chrispsommers
added a commit
to chrispsommers/p4runtime
that referenced
this pull request
Sep 16, 2024
* Added missing "Added/deprecated in v1.4.0" comments per convention. * Added missing "Added/deprecated in v1.4.0" comments per convention. * Refresh generated go files. Signed-off-by: chris <chris.sommers@keysight.com>
chrispsommers
added a commit
that referenced
this pull request
Sep 16, 2024
* Add v1.4.0 comments to protobufs - fix #487 (#490) * Added missing "Added/deprecated in v1.4.0" comments per convention. * Added missing "Added/deprecated in v1.4.0" comments per convention. * Refresh generated go files. Signed-off-by: chris <chris.sommers@keysight.com> * Update Bazel example to point to 1.4.0 (#493) Signed-off-by: Steffen Smolka <smolkaj@google.com> Signed-off-by: chris <chris.sommers@keysight.com> * Regenerate rust code. Signed-off-by: chris <chris.sommers@keysight.com> --------- Signed-off-by: chris <chris.sommers@keysight.com> Signed-off-by: Steffen Smolka <smolkaj@google.com> Co-authored-by: Steffen Smolka <smolkaj@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds to staged version-1.4.0-rc branch which will be merged to main when we're ready to declare a 1.4.0 tag.
I used the following commands to create a temp working file to examine changes since tagged version 1.3.0: