[ASTS] Foreground Task II.B: Add mock-based tests for DefaultSingleBucketSweepTask #7294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyk-91
force-pushed
the
jkong/asts-foreground-torrent-10-4
branch
from
56214dd
to
a919922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Before this PR: #7270 doesn't have tests. Some were proposed in #7288, but those are styled more in the way of integration tests - while they provide value in terms of coverage, identifying what exactly went wrong for those is not exactly trivial.
After this PR:
==COMMIT_MSG==
DefaultSingleBucketSweepTaskhas mock-based tests.==COMMIT_MSG==
Priority: P2
Concerns / possible downsides (what feedback would you like?): Are there any missing test cases? Otherwise nothing in particular.
Is documentation needed?: No.
Compatibility
Does this PR create any API breaks (e.g. at the Java or HTTP layers) - if so, do we have compatibility?: No
Does this PR change the persisted format of any data - if so, do we have forward and backward compatibility?: No
The code in this PR may be part of a blue-green deploy. Can upgrades from previous versions safely coexist? (Consider restarts of blue or green nodes.): Yes
Does this PR rely on statements being true about other products at a deployment - if so, do we have correct product dependencies on these products (or other ways of verifying that these statements are true)?: No
Does this PR need a schema migration? No
Testing and Correctness
What, if any, assumptions are made about the current state of the world? If they change over time, how will we find out?: There are some assumptions about how a sweep queue reader etc. implicitly work in terms of the stubbing. (The integration tests should, however, catch this kind of thing.)
What was existing testing like? What have you done to improve it?: This PR only adds tests.
If this PR contains complex concurrent or asynchronous code, is it correct? The onus is on the PR writer to demonstrate this.: N/A
If this PR involves acquiring locks or other shared resources, how do we ensure that these are always released?: N/A
Execution
This PR only modifies tests.
Scale
This PR only modifies tests.
Development Process
Where should we start reviewing?: The one file
If this PR is in excess of 500 lines excluding versions lock-files, why does it not make sense to split it?:
Please tag any other people who should be aware of this PR:
@jeremyk-91
@sverma30
@raiju