This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fix quotemark avoid-template issues #4408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
suggested changes
Dec 26, 2018
adidahiya
previously requested changes
Jan 9, 2019
|
the fix in the first commit doesn't work; I added some better test cases. there are issues around the rule behavior when both |
4 tasks
adidahiya
reviewed
Jan 10, 2019
| @@ -27,12 +27,12 @@ const OPTION_JSX_DOUBLE = "jsx-double"; | |||
| const OPTION_AVOID_TEMPLATE = "avoid-template"; | |||
| const OPTION_AVOID_ESCAPE = "avoid-escape"; | |||
|
|
|||
| type QUOTE_MARK = "'" | '"' | "`"; | |||
| type JSX_QUOTE_MARK = "'" | '"'; | |||
| type QUOTEMARK = "'" | '"' | "`"; | |||
There was a problem hiding this comment.
I renamed "quote mark" to "quotemark" everywhere to be consistent
JoshuaKGoldberg
approved these changes
Jan 10, 2019
adidahiya
reviewed
Jan 10, 2019
| ); | ||
| } | ||
| ts.forEachChild(node, cb); | ||
| }); | ||
| } | ||
|
|
||
| function getQuotemarkPreference(args: any[]): QUOTE_MARK { | ||
| type QUOTE_PREF = typeof OPTION_SINGLE | typeof OPTION_DOUBLE | typeof OPTION_BACKTICK; |
There was a problem hiding this comment.
also simplified these two helper functions to reduce duplication and the extra typedefs
adidahiya
changed the title
|
thanks @JoshuaKGoldberg |
adidahiya
pushed a commit
that referenced
this pull request
Jan 10, 2019
Merged
ColCh
added a commit
to ColCh/tslint
that referenced
this pull request
Feb 3, 2019
* master: (60 commits) Added tslint-brunch to the list of 3rd party tools (palantir#4251) Switch to tslint-plugin-prettier, clean up rule options config syntax (palantir#4488) Enable grouped-imports for ordered-imports rule in tslint:all config (palantir#4420) Ordered imports grouping (palantir#4134) trailing-comma: check for a closing parenthesis (palantir#4457) Update index.md (palantir#4473) [bugfix] `no-unsafe-any`: allow implicitly downcasting `any` to `unknown` (palantir#4442) Add v5.12.1 changelog Bump version to 5.12.1 Fix quotemark avoid-template issues (palantir#4408) Skip linting JSON files entirely (palantir#4001) Fix strict-type-predicate for unknown (palantir#4444) restrict increment-decrement fixer while fixing the postfix unary expressions (palantir#4415) Mention file names in script parse failures (palantir#4397) Revert breaking change to tslint:recommended, update tslint:latest (palantir#4404) Fix quotemark avoid-template issues (palantir#4408) Bump tslint dev dependency to 5.12.0 (palantir#4452) Skip linting JSON files entirely (palantir#4001) Fix strict-type-predicate for unknown (palantir#4444) [README] Update link for Webstorm (palantir#4450) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
should be(backtick should be backtick) #4402Overview of change:
Add an additonal check to make sure we never render a warning of the format
" should be "or` should be `.Is there anything you'd like reviewers to focus on?
Whats the best test for this? I couldn't find a way to write a test that failed before making this fix, but I feel like we shouldn't merge this without one.
CHANGELOG.md entry:
[bugfix] fix some
quotemarkissues when using backticks with theavoid-templateoption