Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

trailing-comma: check for a closing parenthesis #4457

Merged
merged 1 commit into from
Jan 29, 2019
Merged

trailing-comma: check for a closing parenthesis #4457

merged 1 commit into from
Jan 29, 2019

Conversation

steinuil
Copy link
Contributor

@steinuil steinuil commented Jan 11, 2019

PR checklist

Overview of change:

FIxes an uncaught exception thrown by trailing-comma.

CHANGELOG.md entry:

[bugfix] trailing-comma no longer crashes if it cannot find the closing parenthesis of a function declaration

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @steinuil! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Should a new .ts.lint test case be added for this?

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should try to invalid syntax in .lint files, as invalid TS is technically "unsupported" by TSLint

@adidahiya adidahiya merged commit 8486bf0 into palantir:master Jan 29, 2019
abierbaum pushed a commit to abierbaum/tslint that referenced this pull request Jan 29, 2019
ColCh added a commit to ColCh/tslint that referenced this pull request Feb 3, 2019
* master: (60 commits)
  Added tslint-brunch to the list of 3rd party tools (palantir#4251)
  Switch to tslint-plugin-prettier, clean up rule options config syntax (palantir#4488)
  Enable grouped-imports for ordered-imports rule in tslint:all config (palantir#4420)
  Ordered imports grouping (palantir#4134)
  trailing-comma: check for a closing parenthesis (palantir#4457)
  Update index.md (palantir#4473)
  [bugfix] `no-unsafe-any`: allow implicitly downcasting `any` to `unknown` (palantir#4442)
  Add v5.12.1 changelog
  Bump version to 5.12.1
  Fix quotemark avoid-template issues (palantir#4408)
  Skip linting JSON files entirely (palantir#4001)
  Fix strict-type-predicate for unknown (palantir#4444)
  restrict increment-decrement fixer while fixing the postfix unary expressions (palantir#4415)
  Mention file names in script parse failures (palantir#4397)
  Revert breaking change to tslint:recommended, update tslint:latest (palantir#4404)
  Fix quotemark avoid-template issues (palantir#4408)
  Bump tslint dev dependency to 5.12.0 (palantir#4452)
  Skip linting JSON files entirely (palantir#4001)
  Fix strict-type-predicate for unknown (palantir#4444)
  [README] Update link for Webstorm (palantir#4450)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants