Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatcher: handle worker errors #465

Merged
merged 5 commits into from
Nov 14, 2020

Conversation

maikia
Copy link
Contributor

@maikia maikia commented Nov 13, 2020

The dispatcher gets some unhandled errors when running the worker and it breaks
this is to ensure that the dispatcher does not break

Reference Issue

What does this implement/fix? Explain your changes.

Any other comments?

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #465 (d7abe59) into master (9565765) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   93.37%   93.44%   +0.06%     
==========================================
  Files          99       99              
  Lines        8337     8355      +18     
==========================================
+ Hits         7785     7807      +22     
+ Misses        552      548       -4     
Impacted Files Coverage Δ
ramp-engine/ramp_engine/dispatcher.py 98.11% <100.00%> (+2.57%) ⬆️
ramp-engine/ramp_engine/tests/test_dispatcher.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9565765...d7abe59. Read the comment docs.

Copy link
Collaborator

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @maikia !

I also run into issues of dispatcher stopping due to unhandled exception in the past.

@rth rth merged commit 43310c1 into paris-saclay-cds:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants