Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EngAut] Prepare command-bot scripts to work in monorepo #174

Closed
4 tasks done
Tracked by #126
mordamax opened this issue Mar 22, 2023 · 1 comment
Closed
4 tasks done
Tracked by #126

[EngAut] Prepare command-bot scripts to work in monorepo #174

mordamax opened this issue Mar 22, 2023 · 1 comment
Assignees
@mordamax

Comments

@mordamax
Copy link
Contributor

mordamax commented Mar 22, 2023 •
edited
Loading

Prepare command-bot scripts to work in monorepo & runtimes in fellowship

Context:

What's going to change

How will it impact command-bot?

Since the runtimes are moved out to fellowship org, as stated in forum post, the only thing to test try-runtime and benchmark remains substrate dev pallet. So command-bot-scripts for substrate have to be updated to run it from polkadot-sdk considering the subfolder "substrate" from root of repo + the paths for weights
To simplify usage of command-bot scripts in monorepo, it's better to support "default arguments" which is only possible with named arguments (vs positioned that we have now). This leads also to a change of how we run the commands

Current (Positioned) New (Named)
bot bench $ runtime kusama pallet_name bot bench polkadot-pallet --runtime=kusama --pallet=pallet_name
bot bench $ pallet dev pallet_name bot bench substrate-pallet --pallet=pallet_name
bot bench $ xcm bridge-hub-kusama bridge-hubs pallet_name bot bench cumulus-bridge-hubs --subcommand=xcm --runtime=bridge-hub-kusama --pallet=pallet_name
bot bench $ pallet asset-hub-polkadot assets pallet_balances bot bench cumulus-assets --pallet=pallet_balances
bot bench $ pallet asset-hub-kusama assets pallet_balances bot bench cumulus-assets --runtime=asset-hub-kusama --pallet=pallet_balances
bot try-runtime $ westend bot try-runtime --chain=westend
bot try-runtime $ polkadot bot try-runtime
bot fmt bot fmt

Tasks
Beta Give feedback
@mordamax mordamax self-assigned this Mar 22, 2023
@mordamax
Copy link
Contributor Author

Did quick pre-investigation and formed steps in description

@mordamax mordamax changed the title Prepare command-bot scripts to work in monorepo [EngAut] Prepare command-bot scripts to work in monorepo Jun 1, 2023
@mordamax mordamax mentioned this issue Jun 1, 2023
Closed
8 tasks
@mordamax mordamax mentioned this issue Jun 28, 2023
Merged
mordamax added a commit that referenced this issue Jul 3, 2023
@mordamax
Command bot - named arguments (#208)
1a093fd 
Share credits for idea & part of implementation with @mutantcornholio 
- Fixes #160
- Related #174
  - Implements named arguments for #174 + handy "guess" helper which translates old to a new syntax
  - Improved docs which now filterable by repo and have better command arguments description
- Made "bot ..." configurable in env vars, so we can run local bots on **paritytech-stg** in same repo alongside with staging bots and not interfere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mordamax mordamax

Labels
None yet
Projects
Parity Roadmap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mordamax