Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command bot - named arguments #208

Merged
merged 18 commits into from
Jul 3, 2023
Merged

Command bot - named arguments #208

merged 18 commits into from
Jul 3, 2023

Conversation

mordamax
Copy link
Contributor

@mordamax mordamax commented May 30, 2023

Share credits for idea & part of implementation with @mutantcornholio

image

@mordamax mordamax marked this pull request as ready for review June 28, 2023 23:35
@mordamax mordamax requested review from a team as code owners June 28, 2023 23:35
nodemon.json Outdated Show resolved Hide resolved
src/bot/parse/guessCommand.ts Show resolved Hide resolved
src/command-configs/renderHelpPage.pug Outdated Show resolved Hide resolved
src/command-configs/renderHelpPage.ts Outdated Show resolved Hide resolved
src/commander/commander.ts Outdated Show resolved Hide resolved
src/commander/parseCommand.ts Outdated Show resolved Hide resolved
Signed-off-by: Przemek Rzad <roopert7@gmail.com>
Signed-off-by: Przemek Rzad <roopert7@gmail.com>
),
},
];

describe("parsePullRequestBotCommandLine", () => {
describe.skip("parsePullRequestBotCommandLine", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip is left intentionally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, later will just remove this test after migration

@mordamax mordamax changed the title Improve docs, fix #160, make ref required Command bot - named arguments Jul 3, 2023
@mordamax mordamax requested a review from rzadp July 3, 2023 13:45
Copy link
Contributor

@mutantcornholio mutantcornholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mordamax mordamax merged commit 1a093fd into master Jul 3, 2023
2 checks passed
@mordamax mordamax deleted the mak-named-arguments branch July 3, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running a command with a random text before or after a command ignores the command
4 participants