Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Polkadot companion for Substrate#8420 #2672

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Polkadot companion for Substrate#8420 #2672

merged 3 commits into from
Mar 24, 2021

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Mar 23, 2021

@tomaka tomaka added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. labels Mar 23, 2021
@tomaka tomaka mentioned this pull request Mar 23, 2021
Merged
@tomaka
Copy link
Contributor Author

tomaka commented Mar 24, 2021

Behold resolving conflicts in Cargo.lock with GitHub's UI.

@ghost
Copy link

ghost commented Mar 24, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Mar 24, 2021

Merge failed: "Required status check \"continuous-integration/gitlab-check-transaction-versions\" is expected. At least 1 approving review is required by reviewers with write access."

@tomaka tomaka merged commit 73a146f into master Mar 24, 2021
@tomaka tomaka deleted the tka-companion-8420 branch March 24, 2021 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@romanb romanb romanb approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomaka @romanb @bkchr