Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update to libp2p-0.36 #8420

Merged
2 commits merged into from
Mar 24, 2021
Merged

Update to libp2p-0.36 #8420

2 commits merged into from
Mar 24, 2021

Conversation

romanb
Copy link
Contributor

@romanb romanb commented Mar 22, 2021

This PR updates libp2p to 0.36. The full changelog compared to 0.35.1 can be seen here. The highlights are:

Given the larger changes to the (M)DNS libraries, a burn-in may be appropriate.

polkadot companion: paritytech/polkadot#2672

@romanb romanb added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 22, 2021
@romanb romanb added D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit and removed D2-breaksapi labels Mar 22, 2021
@tomaka
Copy link
Contributor

tomaka commented Mar 22, 2021

Note: I had to run cargo update -p data-encoding -p futures:0.3.12 -p winapi:0.2.8 -p futures-lite to get Polkadot to build.

@tomaka
Copy link
Contributor

tomaka commented Mar 22, 2021

Also cargo update -p fs-swap -p winapi:0.2.8, otherwise you get compilation errors when building fs-swap.

@tomaka
Copy link
Contributor

tomaka commented Mar 23, 2021

Burn-in looks fine.

One thing that is curious is that before this PR we had little peaks to the number of libp2p tasks, presumably because of the periodic Kademlia requests. Now these peaks are gone.

image

The same shows on the number of connections. There are still little peaks of number of connections every 10 minutes, when Kademlia requests trigger, but they are way less pronounced.

Anyway, everything seems to work as intended. I think we need a Polkadot companion PR however.

@romanb
Copy link
Contributor Author

romanb commented Mar 23, 2021

I think we need a Polkadot companion PR however.

Can we repurpose paritytech/polkadot#2659 to serve as the companion?

@tomaka tomaka requested review from bkchr and eskimor March 24, 2021 16:02
@tomaka
Copy link
Contributor

tomaka commented Mar 24, 2021

I have no idea who to ask for reviews 🙃

@tomaka
Copy link
Contributor

tomaka commented Mar 24, 2021

The Polkadot companion needs two approvals as well.

EDIT: as long as I don't restart the CI check, probably no.

@tomaka
Copy link
Contributor

tomaka commented Mar 24, 2021

bot merge

@ghost
Copy link

ghost commented Mar 24, 2021

Trying merge.

@ghost ghost merged commit 67695c8 into paritytech:master Mar 24, 2021
hirschenberger pushed a commit to hirschenberger/substrate that referenced this pull request Apr 14, 2021
* Update to libp2p-0.36

* Some more Cargo.lock updates.
jordy25519 pushed a commit to cennznet/substrate that referenced this pull request Sep 17, 2021
* Update to libp2p-0.36

* Some more Cargo.lock updates.
thadouk pushed a commit to Aventus-Network-Services/substrate that referenced this pull request Oct 21, 2021
Part of the upgrade to substrate 3.0
Updating some of the cargo dependencies that the original
packages in substrate 3.0 release are no longer available.

Update to libp2p-0.35.1 (paritytech#8141)

Update to libp2p-0.36 (paritytech#8420)

* Update to libp2p-0.36

* Some more Cargo.lock updates.

Update to libp2p-0.35.1 (paritytech#8141)

This commit can be dropped in future upgrades
thadouk added a commit to Aventus-Network-Services/substrate that referenced this pull request Oct 21, 2021
Part of the upgrade to substrate 3.0
Updating some of the cargo dependencies that the original
packages in substrate 3.0 release are no longer available.

Unbreak browser test CI (paritytech#8148)

Update to libp2p-0.35.1 (paritytech#8141)

Update to libp2p-0.36 (paritytech#8420)

* Update to libp2p-0.36

* Some more Cargo.lock updates.

Update to libp2p-0.35.1 (paritytech#8141)

This commit can be dropped in future upgrades
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants