Skip to content

Commit

Permalink
fix!: minimum nodejs version (#1278)
Browse files Browse the repository at this point in the history
  • Loading branch information
TarikGul committed May 1, 2023
1 parent 44e2da4 commit 05628da
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 29 deletions.
21 changes: 2 additions & 19 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [14.x]
node-version: [18.x]

steps:
- name: Install wasm-pack
Expand All @@ -31,23 +31,6 @@ jobs:
- run: yarn
- run: yarn build

build-docs:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [14.x]

steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: yarn
- run: yarn build:docs

build-npm-release:
# This test is to make sure sidecar can release a binary without any errors.
# This script does not publish a release, but instead uses yarn to create a tarball and
Expand All @@ -59,7 +42,7 @@ jobs:

strategy:
matrix:
node-version: [14.x]
node-version: [18.x]

steps:
- uses: actions/checkout@v3
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ jobs:
- name: Checkout files
uses: actions/checkout@v3

- name: Install Node v16
- name: Install Node v18
uses: actions/setup-node@v3
with:
node-version: '16.13'
node-version: '18.14'

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand All @@ -48,10 +48,10 @@ jobs:
- name: Checkout files
uses: actions/checkout@v3

- name: Install Node v16
- name: Install Node v18
uses: actions/setup-node@v3
with:
node-version: '16.13'
node-version: '18.14'

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -79,10 +79,10 @@ jobs:
- name: Checkout files
uses: actions/checkout@v3

- name: Install Node v16
- name: Install Node v18
uses: actions/setup-node@v3
with:
node-version: '16.13'
node-version: '18.14'

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down Expand Up @@ -110,10 +110,10 @@ jobs:
- name: Checkout files
uses: actions/checkout@v3

- name: Install Node v16
- name: Install Node v18
uses: actions/setup-node@v3
with:
node-version: '16.13'
node-version: '18.14'

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14
v18.15
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ learn more.

## Prerequisites

### <= v15.0.0
This service requires Node versions 14 or higher.

Compatibility:
Expand All @@ -39,6 +40,15 @@ Compatibility:
| v18.x.x | Stable |
| v19.x.x | Pending |

### >= v16.0.0
This service requires Node versions 18.14 or higher.

Compatibility:
| Node Version | Stablility |
|---------------|:-----------:|
| v18.14.x | Stable |
| v19.x.x | Pending |

NOTE: Node LTS (`long term support`) versions start with an even number, and odd number versions are subject to a 6 month testing period with active support before they are unsupported. It is recommended to use sidecar with a stable actively maintained version of node.js.

## Table of contents
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"url": "git+https://github.com/paritytech/substrate-api-sidecar.git"
},
"engines": {
"node": ">=14"
"node": ">=18.14"
},
"bugs": {
"url": "https://github.com/paritytech/substrate-api-sidecar/issues"
Expand Down

0 comments on commit 05628da

Please sign in to comment.