fix!: minimum nodejs version #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergejparity
approved these changes
May 1, 2023
marshacb
approved these changes
May 1, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
This changes the minimum nodejs version to 18.14 to keep it in line with polkadot-js for future versions.
This is a necessary change since I noticed some syntax errors inside of this #1277 . When buiding the the sidecar package using the new polkadot-js versions I saw that there was some incompatible syntax warning (
not recognized). But when I switched it to v16 it worked. Therefore, I am using this as a opportunity to keep it completely inline with polkadot-js and enforce v18.14.