-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus Metrics #1008
Comments
It's definitely possible to integrate prometheus into Sidecar as we have the helm setup already intrinsic to the Repo. I am not totally sure on what the workload on integration would look like though - @ArshamTeymouri Any thoughts on this? |
Hi Tarik! That's a great idea to have the metrics exposed by the application. For this, we need a new endpoint on the application, say Besides, two additional endpoints should also be introduced, We have already done the same thing for one of the internal tools, Gitspiegel. You can reference its corresponding issue and PR for more details: https://github.com/paritytech/gitspiegel/issues/84 Once those endpoints are in place, I can proceed with configuring Prometheus to scrape the metrics and store them in its database. Later, you would be able to create your own dashboards on Grafana and visualize your application performance with fancy panels. Feel free to reach me on Matrix if you need anything. |
@ArshamTeymouri I love the idea of adding the Implementing and exposing the basic metrics at |
@ArshamTeymouri I was looking into the issue and I was wondering if it is recommended to run the |
@Imod7 sorry for the late reply, I was on a long vacation. |
Current Status of this Issue
|
I integrated metrics support into our substrate node helm-chart (paritytech/helm-charts#284), However I don't see a lot of useful metrics exposed beyond the default nodejs cpu/mem. For example, it would be useful to have histogram of response times for each HTTP endpoint. |
@PierreBesson thank you so much for the feedback! 💯 🙏 Yes, indeed, it does not have a lot of useful metrics right now since my goal through the 1st iteration was to build the base where later we could add any metrics we think are useful. Also, I think it needs a proper research on what metrics would be useful in a rest api and I have not done this (yet!) so your suggestion is a huge help. Please share if you have any other ideas/suggestions/recommendations/links on what I should check. For now, I will add the histogram metric in the pending list (my previous/comment above). |
what is the status on this one? @Imod7 |
The status is reflected in this comment which shows :
Also, this comment shows that further research can be done to come up with other (than the 2 metrics suggested above) metrics that might useful. |
This PR integrated HTTP metrics for all routes [PR #1465 ] |
Proposed Change or Idea
Add prometheus metrics for monitoring the health of a sidecar instance.
Steps:
First Metrics
Additional Information
In order to provide a clean consistent service. You need to be able to easily monitor the health and status of each service.
The text was updated successfully, but these errors were encountered: