-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add route based metrics across API #1465
Conversation
Overall this is really well done. Just a few nits to clean this up. Feel free to ping me when this changes from being a draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job! Lgtm 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Those metrics are great additions! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Just a last tiny comment.
Very excited with these metrics and what insights they will give us in Sidecar's performance.
Enables the metrics for all routes available in the API. An extra arg "-pq" has been created to allow the user to select if queryparams should be taken into consideration when creating metrics. An extra command has been included to run all benchmarks in one command in /benchmarks/init.sh
the following histograms have been created:
example use:
yarn dev -p => metrics route based
yarn dev -p -pq => metrics route based with queryparams