chore(release): 19.1.0 #1478
chore(release): 19.1.0 #1478
Conversation
CHANGELOG.md
Outdated
| ## Compatibility | ||
|
|
||
| Tested against: | ||
| - Polkadot v11500 (v1.15.0 / stable2407) |
There was a problem hiding this comment.
If these are referring to specVersion, I thought it was v1015000 same for the below v1013000
There was a problem hiding this comment.
I am not sure it makes sense to talk about spec version here. These versions will never hit Polkadot or Kusama runtimes.
I think we need to be more precise and tell apart between the Polkadot-SDK node release and the versions hitting Polkadot, Kusama, and Westend RCs.
There was a problem hiding this comment.
Yea that definitely makes sense! I agree probably best to just mention the latest live polkadot kusama and westend runtimes.
There was a problem hiding this comment.
Yes, regarding the compatibility versioning. So, as you know I changed the formatting in the last release here and my reasoning was the following:
I noticed that in the section Assets of v1.13.0 release notes, some assets are labeled as v1013000, e.g. asset-hub-rococo_runtime-v1013000.compact.compressed.wasm so I think this is the correct way to denote the client version.
However, I had doubts now if this is the ideal way to represent the node version so I reverted back to how it used to be, so 11500. The reasons are the following :
11500looks more compact11500is the formatting we used until now so I thought it is best to keep it and in case of doubts I now add the version inx.x.xformat1015000has the same formatting as the runtime and I thought that it might cause confusion.
Having said that, if you think my previous change was better then I will go back to the v1015000 format. I think a good idea is to also change the title from Compatibility to Node Compatibility.
There was a problem hiding this comment.
In terms of node compatibility, I am all good with that @Imod7 said in the last comment.
What it is not so clear to me is what to do with runtime compatibility. When runtimes and node releases were split, we didn't make any differentiation in the release notes but I think it makes sense to mention compatibility with runtimes too. Bear in mind that runtime releases for Westend are contained in the Polkadot-SDK release, so it would be something like:
Compatibility
-
Tested against the following node releases:
- Polkadot v1.15.0
- Kusama v1.15.0
- Westend v1.15.0
-
Tested against the following runtime releases:
- Polkadot v1002007
- Kusama v1002006
- Westend v1015000
There was a problem hiding this comment.
I really like this actually. Super clear and leaves no room for confusion 💯 Thank you! I will change it now.
There was a problem hiding this comment.
Changed it here:
- I also added
(Polkadot stable2407)next to the node releases so it is aligned with the p-sdk releases page. - I was thinking of making it even more clear by adding the corresponding links but then for Westend it will be confusing.
Description
This is a
minorrelease for Sidecar since:Notes
In the compatibility section (CHANGELOG), I reverted the node version in the previous format. Also, added in parenthesis the node release in the format (vX.XX.XX) as it appears on the Polkadot releases page to avoid any confusion.