ci: build container on release #396
Conversation
…build container; edit docker-compose
There was a problem hiding this comment.
Thanks @TriplEight !! I don't fully understand all the pieces so worth a look over by a set of eyes with more workflows/docker experience
|
Sorry, it had to take so long to get here. |
|
Now it can be merged. this is a bit tricky with that
So please ping me if this action will crash on release. |
emostov
changed the title
| env: | ||
| REGISTRY: docker.io/parity | ||
| IMAGE_NAME: substrate-api-sidecar | ||
| # IMAGE_TAG: ${{ matrix.tag }} |
There was a problem hiding this comment.
I left it as an explanatory comment
| yarn build | ||
|
|
||
| # --------------------------------- | ||
|
|
||
| FROM node:15-alpine | ||
| FROM docker.io/library/node:15-alpine |
There was a problem hiding this comment.
Am I right in thinking /library/ is equivalent to /_/ on hub.docker.com?
There was a problem hiding this comment.
yes, /_/ is the alias for /library/
There was a problem hiding this comment.
not sure about now, but earlier versions of buildah didn't have the docker registry configured by default and it was confusing. Buildah did not understand the docker-style shortened image addresses i.e. node:15 or parity/substrate-api-sidecar and demanded a fqdn everywhere.
Then it softened and now buildah is able to deduct the image address (when you build manually with just node:15 in FROM it will stop and ask where to take it from - QUAY or dockehub), but still it will throw an error on push if you built an image without the registry address in name.
Closes: paritytech/ci_cd/issues/51
Closes: #333