Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: build container on release #396
ci: build container on release #396
Changes from all commits
c2b65da
e19132c
67a7cd9
d38ff22
7424892
6e53c12
d7bc7f1
a76ae03
2ebd596
4f86526
40533a6
3726509
5637a8f
9939990
4c28697
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I right in thinking
/library/
is equivalent to/_/
on hub.docker.com?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes,
/_/
is the alias for/library/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about now, but earlier versions of buildah didn't have the docker registry configured by default and it was confusing. Buildah did not understand the docker-style shortened image addresses i.e.
node:15
orparity/substrate-api-sidecar
and demanded a fqdn everywhere.Then it softened and now buildah is able to deduct the image address (when you build manually with just
node:15
inFROM
it will stop and ask where to take it from - QUAY or dockehub), but still it will throw an error onpush
if you built an image without the registry address in name.