ci: update node version in docker #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
commented
Jun 13, 2022
Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM docker.io/library/node:15 as builder | |||
| FROM docker.io/library/node:16 as builder | |||
There was a problem hiding this comment.
Both FROM docker.io... should have the same node version? 16.15.1
There was a problem hiding this comment.
It depends on what we are trying to achieve. If we keep node:16 then docker will use the latest image version. Otherwise the version will be constant (e.g. 16.15.1).
There was a problem hiding this comment.
I guess the point here is to use a fixed, reproducable version of node for the built image, but to allow minor updates and such in the container used to do the building?
I've no strong opinion either way; I'd probably lean to using 16.15.1 in both places to keep both stages as reproducable as possible (with the tradeoff of not getting security updates to either), but shrug!
alvicsam
approved these changes
Jun 20, 2022
jsdw
approved these changes
Jun 20, 2022
sergejparity
approved these changes
Jun 20, 2022
lexnv
approved these changes
Jun 20, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.