Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update node version in docker #956

Merged
merged 2 commits into from
Jun 20, 2022
Merged

ci: update node version in docker #956

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
865d64b
ci: update node version in docker
TarikGul Jun 13, 2022
f88a72a
set builder to 16.15.1-alpine
TarikGul Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM docker.io/library/node:15 as builder
FROM docker.io/library/node:16 as builder
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both FROM docker.io... should have the same node version? 16.15.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on what we are trying to achieve. If we keep node:16 then docker will use the latest image version. Otherwise the version will be constant (e.g. 16.15.1).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the point here is to use a fixed, reproducable version of node for the built image, but to allow minor updates and such in the container used to do the building?

I've no strong opinion either way; I'd probably lean to using 16.15.1 in both places to keep both stages as reproducable as possible (with the tradeoff of not getting security updates to either), but shrug!


WORKDIR /opt/builder

Expand All @@ -9,7 +9,7 @@ RUN yarn install && \

# ---------------------------------

FROM docker.io/library/node:15-alpine
FROM docker.io/library/node:16.15.1-alpine

# metadata
ARG VERSION=""
Expand Down