Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a data type constant for pmix_nspace_t #334

Merged
merged 1 commit into from
May 20, 2021
Merged

Conversation

rhc54
Copy link
Member

@rhc54 rhc54 commented Jan 31, 2021

Define a data type solely for process namespace as we did for process rank.

Signed-off-by: Ralph Castain rhc@pmix.org

@rhc54 rhc54 added the RFC Request for Comment label Jan 31, 2021
@rhc54 rhc54 added this to the PMIx v4.1 Standard milestone Jan 31, 2021
@rhc54 rhc54 self-assigned this Jan 31, 2021
@rhc54
Copy link
Member Author

rhc54 commented Jan 31, 2021

Please use emoji reactions ON THIS COMMENT to indicate your position on this proposal.

  • You do not need to vote on every proposal
  • If you have no opinion, don't vote - that is also useful data
  • If you've already commented on this issue, please still vote so
    we know your current thoughts
  • Not all proposals solve exactly the same problem, so we may end
    up accepting proposals that appear to have some overlap
    This is not a binding majority-rule vote, but it will be a very
    significant input into the corresponding ASC decision.

Here are the meanings for the emojis:

  • Hooray or Rocket: I support this so strongly that I
    want to be an advocate for it
  • Heart: I think this is an ideal solution
  • Thumbs up: I'd be happy with this solution
  • Confused: I'd rather we not do this, but I can tolerate it
  • Thumbs down: I'd be actively unhappy, and may even consider
    other technologies instead
    If you want to explain in more detail, feel free to add another
    comment, but please also vote on this comment.

@jjhursey
Copy link
Member

jjhursey commented Apr 7, 2021

This PR adds a new constant. This PR is on the provisional track.

@jjhursey jjhursey added the Eligible Eligible for consideration by ASC label Apr 7, 2021
jjhursey
jjhursey previously approved these changes Apr 8, 2021
@jjhursey
Copy link
Member

jjhursey commented Apr 9, 2021

Implementation Reference:

@raffenet
Copy link
Contributor

A procedural question: I see this and other 4.1 release related items are based against the v4 branch. How will we go about also including them in master, if accepted?

@jjhursey
Copy link
Member

A procedural question: I see this and other 4.1 release related items are based against the v4 branch. How will we go about also including them in master, if accepted?

Yeah, they should go into master first then we will cherry-pick them over - unless, for some reason, the change only applies to the particular release series. We should be able to change the target branch without creating a new PR. Thanks for catching that.

@kathrynmohror kathrynmohror added the Accepted as Provisional ASC vote passed. Accepted as Provisional! label May 14, 2021
@jjhursey
Copy link
Member

jjhursey commented May 20, 2021

PMIx ASC 2Q 2021: May 11 & May 13

  • Passed first vote: 5 yes / 0 no / 3 abstain
  • This has been accepted as provisional.
  • I will do the following today:
    • Update the branch
    • Merge it into v4
    • Cherry-pick to master

Define a data type solely for process namespace as we did for process rank.

Signed-off-by: Ralph Castain <rhc@pmix.org>
@jjhursey
Copy link
Member

  • Update the branch to v4 HEAD
  • Merge it into v4
  • No other text changes made

@jjhursey jjhursey merged commit 97c95aa into pmix:v4 May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted as Provisional ASC vote passed. Accepted as Provisional! Eligible Eligible for consideration by ASC RFC Request for Comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants