Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick of v4 Provisional and Errata #351

Merged
merged 16 commits into from
May 26, 2021
Merged

Conversation

rhc54 and others added 15 commits May 20, 2021 10:11
The event handler registration ordering is based on event handler names, not event handler reference IDs

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit ce9461c)
While we provided macros for these purposes, it turns out that the logic in implementing those macros is somewhat more complex that originally realized and better suited to an actual function call. This RFC adds to functions to the Data Management chapter:

- PMIx_Data_load transfers a data "blob" from a pmix_byte_object_t structure to a pmix_data_buffer_t

- PMIx_Data_unload transfers the payload in a pmix_data_buffer_t to a pmix_byte_object_t structure

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit f5324ca)
Signed-off-by: Ralph Castain <rhc@pmix.org>

Co-authored-by: Josh Hursey <4259120+jjhursey@users.noreply.github.com>
(cherry picked from commit 8253630)
Signed-off-by: Ralph Castain <rhc@pmix.org>

Co-authored-by: Josh Hursey <4259120+jjhursey@users.noreply.github.com>
(cherry picked from commit 545d6a3)
Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit 241ae71)
Signed-off-by: Ralph Castain <rhc@pmix.org>

Co-authored-by: Ken Raffenetti <raffenet@users.noreply.github.com>
(cherry picked from commit 97d453b)
Signed-off-by: Ralph Castain <rhc@pmix.org>

Co-authored-by: Ken Raffenetti <raffenet@users.noreply.github.com>
(cherry picked from commit 2d99f05)
PMIX_RANK_IS_VALID - test if a rank has a valid value (i.e., less thatn PMIX_RANK_VALID)

PMIX_NSPACE_INVALID - test if a pmix_nspace_t contains a valid value (i.e., string of length greater than zero)

PMIX_PROCID_INVALID - check for invalid namespace or rank

PMIX_XFER_PROCID - copy a process ID between pmix_proc_t structures

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit 4fea9cd)
Co-authored-by: Josh Hursey <4259120+jjhursey@users.noreply.github.com>
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
(cherry picked from commit 562233d)
Co-authored-by: Josh Hursey <4259120+jjhursey@users.noreply.github.com>
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
(cherry picked from commit 9c79502)
Signed-off-by: Ralph Castain <rhc@pmix.org>

Co-authored-by: Aurelien Bouteiller <bouteill@icl.utk.edu>
(cherry picked from commit 79a0b8e)
Signed-off-by: Ralph Castain <rhc@pmix.org>

Co-authored-by: Aurelien Bouteiller <bouteill@icl.utk.edu>
(cherry picked from commit 85125bc)
Signed-off-by: Ralph Castain <rhc@pmix.org>

Co-authored-by: Aurelien Bouteiller <bouteill@icl.utk.edu>
(cherry picked from commit 672703d)
Signed-off-by: Ralph Castain <rhc@pmix.org>

Co-authored-by: Aurelien Bouteiller <bouteill@icl.utk.edu>
(cherry picked from commit 215da9b)
Define a data type solely for process namespace as we did for process rank.

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit d7b9e7d)
@jjhursey jjhursey added this to the PMIx v5 Standard milestone May 20, 2021
@jjhursey jjhursey requested a review from a team May 20, 2021 15:26
@jjhursey
Copy link
Member Author

I need to add the provisional markers (which we will cherry-pick back to v4 once this is merged).

 * Add `\versionMarkerProvisional` that marks the version level and adds
   the provisoinal designation.

Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
@jjhursey
Copy link
Member Author

While adding the provisional markers (last commit) I noticed a LaTeX rendering issue where the marker might not appear if it is rendered too close to the top of the page. I opened Issue #352 to track the fix. We will do that separate from this PR.

@jjhursey jjhursey removed the WorkInProgress Work In Progress label May 20, 2021
@jjhursey jjhursey marked this pull request as ready for review May 20, 2021 16:00
@jjhursey jjhursey requested review from dsolt and raffenet and removed request for a team May 20, 2021 16:23
@jjhursey jjhursey merged commit 67b3ae0 into pmix:master May 26, 2021
@jjhursey jjhursey deleted the cp-v4-items branch May 26, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants