(Feature) HD wallets' support

[vbaranov]

Menu item:

Choose HD wallet page:

Trezor:

Ledger:

Guide to configure Trezor simulator: https://github.com/poanetwork/nifty-wallet/blob/master/docs/trezor-emulator.md

[dennis00010011b]

@vbaranov
Improper error message if 2nd attempt to connect to Trezor

Steps (don't plug-in HD wallet)

1. Go to 'Connect to hardware wallet'
2. Select 'Trezor', click 'Connect'
3. Switch account or refresh the page, main screen will opens
4. Go to 'Connect to hardware wallet'
5. Select 'Trezor', click 'Connect'

[dennis00010011b]

@vbaranov
Misspelling in notification. Letter 'd' in word 'device' should be capital

[dennis00010011b]

@vbaranov
See #183 (comment)
App is frozen if attempting to delete Trezor's account after choice to forget device

Steps for reproduce:

1. Connect TrezorOne device to PC
2. Open NW, import any account from device
3. Go to Accounts-> Connect hw and click 'Forget this device'
4. Open Accounts and select close icon for deleting Trezor's account

Actual result:

• app unresponsive
• uncaught errors in console fmdpnlapjechkkicpkahdmanomngknlf-1542081145709.txt

Expected result:

• user should be able to delete hw account at any time
  OR
• hw accounts should be removed if user selects to forget device

[vbaranov]

@dennis00010011b

Improper error message if 2nd attempt to connect to Trezor

Fixed here a33ba78

App is frozen if attempting to delete Trezor's account after choice to forget device

Good catch! Also, fixed here a33ba78

Misspelling in notification. Letter 'd' in word 'device' should be capital

Fixed here bad4943

[dennis00010011b]

Improper error message if 2nd attempt to connect to Trezor

Fixed here a33ba78

App is frozen if attempting to delete Trezor's account after choice to forget device

Good catch! Also, fixed here a33ba78

Misspelling in notification. Letter 'd' in word 'device' should be capital

Fixed here bad4943

Tested it with Trezor One device. These issues were not found

[dennis00010011b]

@vbaranov
Uncaught error in console when try to export private key for Trezor's account

[dennis00010011b]

@vbaranov
Ledger: notification's text is incorrect when a transaction rejected by device

[dennis00010011b]

@vbaranov
Error messages should be more friendly and understandable for non-proficient user. Something like that:

1. Please plug-in Ledger, open Eth app and try again

2. Can not recognize device

3. Ledger connection issues, follow the instruction https://support.ledgerwallet.com/hc/en-us/articles/115005165269-Fix-connection-issues

[dennis00010011b]

@vbaranov
Ledger: list of accounts is lost (reconnection is needed ) when user exports the private key for any account
https://www.useloom.com/share/b83694df7c544a59b2849b33d9ac4899
Steps:

1. Connect Ledger, unlock any account
2. Export PR for any account
3. Go to Accounts-> Connect HW

Expected result: list of accounts should be displayed
Actual result: reconnection is needed

Same things happens when delete account
Device isn't really disconnected, just account list isn't displayed

[dennis00010011b]

@vbaranov
Empty screen while waiting for confirmation from device. Could be better to display text 'Please confirm on device ...' and countdown timer for 30 sec (because NW automatically fails of transaction if there is no confirmation from device in during 30 sec)

[vbaranov]

@dennis00010011b

Ledger: notification's text is incorrect when a transaction rejected by device

This has been fixed.

Please, create separate issues for other findings. I think we could solve them in a separate PRs. They require some sort of refactoring. As about friendly errors, of course, we can parse errors from HD wallet and display friendly errors, but it will be hard to manage because errors definitions from HD device are out from our control, and if errors will be changed on HD wallet side, every time we will need to change parsing on NW side.

[fvictorio]

This function seems to do the same as capitalizeFirstLetter.

[vbaranov]

Thanks. Duplicate has been removed 256e585