CI: Enable try-runtime idempotency check

[ggwpez]

Enable one more check in the CI to ensure that our migrations are idempotent. Can only merge after #118

[ggwpez]

Looks like the spec-version check fails. Should i just bump all the versions by one in this MR or disable the check again @bkchr ?

[bkchr]

IMO it would cool if we could enable this check optionally based on if the pr wants to release a new version. See here on how to detect if the changelog changes from unreleased to "released".

[s0me0ne-unkn0wn]

Not sure if it's the right place to raise this question, but it's close enough. Currently, #56 bumps frame-system to 24.0.0 in this release. But to ensure the idempotency of migrations requiring spec version checks (see paritytech/polkadot-sdk#2265) we need frame-system to be at least 27.0.0. I'm not familiar with this versioning, so I'm afraid to screw things up if I do that bump myself without any guidance (especially considering I've already broken everything locally when I tried). So what's the procedure for bumping FRAME and Substrate crate versions in runtimes?

@ordian do we need to push with im-online removal in this very release?

[ggwpez]

But to ensure the idempotency of migrations requiring spec version checks (see paritytech/polkadot-sdk#2265) we need frame-system to be at least 27.0.0

I guess we have to delete it manually this time?

[s0me0ne-unkn0wn]

I guess we have to delete it manually this time?

Not sure I follow, what do we delete manually?

[ggwpez]

I guess we have to delete it manually this time?

Not sure I follow, what do we delete manually?

The migration i mean. We delete it after it executed on-chain.

[s0me0ne-unkn0wn]

The migration i mean. We delete it after it executed on-chain.

Ah yes. We can do that, sure. But that's not the only problem. Your PR enables mandatory idempotency checks. And without spec version checking API, my migration cannot be idempotent because the structure updated is not versioned. And that spec version checking API (last_runtime_upgrade_spec_version()) has been introduced in frame-system 27.0.0.

[bkchr]

@ordian do we need to push with im-online removal in this very release?

No. I already told you this in element. Just wait for the next release.

[s0me0ne-unkn0wn]

No. I already told you this in element. Just wait for the next release.

That's the elaboration of your answer I waited for! 😃 Thanks, we're just postponing it then.

[ggwpez]

Okay so we basically have to ignore the idempotency check until the next runtime upgrade on Polkadot... I will selectively disable it.