Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Enable try-runtime idempotency check #133

Merged
merged 11 commits into from
Jan 9, 2024
Merged

CI: Enable try-runtime idempotency check #133

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ece6939
CI: Enable try-runtime idempotency check
ggwpez Jan 4, 2024
54c76d5
Update to try-runtime-cli 0.5.2
ggwpez Jan 4, 2024
6ae71ef
Also enable spec version check
ggwpez Jan 4, 2024
1c0a479
Also check try-state invariants
ggwpez Jan 4, 2024
07401ff
Fix ci command
ggwpez Jan 4, 2024
3f4ba3b
remove snapshotting
ggwpez Jan 4, 2024
1a49d7f
Merge branch 'main' into oty-try-runtime-checks
ggwpez Jan 4, 2024
6f09bc7
Merge branch 'main' into oty-try-runtime-checks
ggwpez Jan 5, 2024
ca98e4a
Debug polkadot migration check
ggwpez Jan 5, 2024
18d9e16
Selectively disable the idempotency check on polkadot
ggwpez Jan 5, 2024
7307112
Merge branch 'main' into oty-try-runtime-checks
ggwpez Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/check-migrations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:

- name: Download try-runtime-cli
run: |
curl -sL https://github.com/paritytech/try-runtime-cli/releases/download/v0.5.0/try-runtime-x86_64-unknown-linux-musl -o try-runtime
curl -sL https://github.com/paritytech/try-runtime-cli/releases/download/v0.5.2/try-runtime-x86_64-unknown-linux-musl -o try-runtime
chmod +x ./try-runtime

- name: Install Protoc
Expand All @@ -71,10 +71,6 @@ jobs:
if [[ "${{ matrix.runtime.is_relay }}" == "true" ]]; then
NO_WEIGHT_WARNINGS_FLAG="--no-weight-warnings"
fi
# Disable idempotency checks for now because the Scheduler pallet MigrateToV1 migration is
# non-idempotent at its root in Polkadot SDK V1.2.0. In V1.3.0 we can re-enable
# idempotency checks.
EXTRA_ARGS="--disable-spec-version-check --disable-idempotency-checks"
./try-runtime \
--runtime ./target/production/wbuild/$PACKAGE_NAME/$RUNTIME_BLOB_NAME \
on-runtime-upgrade --checks=pre-and-post $EXTRA_ARGS $NO_WEIGHT_WARNINGS_FLAG live --uri ${{ matrix.runtime.uri }}
Loading