-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make input_selectize work correctly within a module #1091
Conversation
thanks @jcheng5 much appreciated! |
Update selectize control to require selectized class
state.set("IA") | ||
|
||
state.expect_selected("IA") | ||
# TODO: This test was being run against input_select, not input_selectize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels off to me. I'd like double check this in the morning before we merge the PR.
Everything else is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. To my knowledge, selectize.js changed how it stores options / selected values.
Either way, if we would have used the correct selectize testing class, the error would have been surfaced earlier.
Yes, we should do this in a followup PR as the changes are not related to this Issue
Co-authored-by: Barret Schloerke <barret@posit.co>
* main: Bump version to 0.7.1.9000 Fix input_task_button for modules (#1108) Bump version to 0.7.1 Test input task button and extended task decorator (#1099) Add remaining examples for express API reference (#1093) test: Add `make playwright-debug` to help debug playwright tests (#1097) Make input_selectize work correctly within a module (#1091) Update types to allow `navset_*` functions to accept `MetadataNode` args (#1094) Update changelog Update express.ui.hold() to accept any type of object (#1089)
TODO
Description
User adam_pinky reported this on Discord:
https://shinylive.io/py/editor/#code=NobwRAdghgtgpmAXGKAHVA6VBPMAaMAYwHsIAXOcpMASxlWICcyACAZwAsaJsAdCfvwACnbtgwxiAEwCuAGzgYZNflLgAzFpNkKA+soAUAShYBaAHzsuPDGWyo4bDADkoANwDKcMgEFGAc0R+FhCWXjBw8IAhZTkpLWl5OBYARhYAVQBJSIiIiFCWRm8ZRnzRG2UMaDddVCgIODkDYILQ8O0klPC8FtarMSUaDG5UGTJdNka4QjIaAC84Zvy+1vCaKW7elZDwuSgAI0a2TeXtkOAUvBYAJiuAZiuAFgBdHtOzmHlZ1AUAXgAVRgyOBvbZGUGhIyCAQQETWcQdBQYSaMNxwRiqDQJHRwCbotGMAxoVC6EZjRD9GyZCCjMhsK7EMa0inlcQAeSZY3pLF0JgsLGcpDgQXeOWisXiAFlEgpUiwvKj0WK8tC1JoUQSDLorrptTzdUYRQVlR54VooNx2PilblIu9EbiNejmmAHV0wFCYfwsixfpTxJU6v5cdV9lBCVsHfoaC63eFwfxPfxib7-RgfOgDFkrk7GJ6wABfZ5AA