-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining examples for express API reference #1093
Conversation
@cpsievert I added the remaining examples and took out the guardrails so that from now on missing examples in Express docs will throw in CI. I also realized we hadn't accounted for Express functions being documented in the Core reference, so I updated the logic to automatically pick |
Oh, good catch, this is actually an oversight on my part...I think it'd be best not to include those Express functions in the Core docs? |
shiny/api-examples/panel_title/rsconnect-python/panel_title.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few suggestions above, and maybe a couple of accidentally included files.
(I didn't read every line but I did skim all of the files.)
* main: Bump version to 0.7.1.9000 Fix input_task_button for modules (#1108) Bump version to 0.7.1 Test input task button and extended task decorator (#1099) Add remaining examples for express API reference (#1093) test: Add `make playwright-debug` to help debug playwright tests (#1097) Make input_selectize work correctly within a module (#1091) Update types to allow `navset_*` functions to accept `MetadataNode` args (#1094) Update changelog Update express.ui.hold() to accept any type of object (#1089)
Closes #1080
@gadenbuie want to add the handful of
update_*()
examples you did?