test: Fix deploys for shinyapps.io and connect #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
reviewed
Mar 19, 2024
karangattu
changed the title
schloerke
approved these changes
Mar 26, 2024
schloerke
added a commit
that referenced
this pull request
Mar 28, 2024
* main: test(CI): Add merge queue support for faster PR testing (#1265) fix(panel_conditional): Include `.shiny-panel-conditional` class (#1257) feat: Create `Session.set_message_handler(name, handler)` (#1253) Fix input name Enable error console when running locally. (#1060) test: Update test to use variable, not capture stdout (#1236) test: Fix deploys for shinyapps.io and connect (#1224) chore(test): Playwright test refactors and clean up (#1204)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unreachable code and modify condition to have the deploy tests run not only when the branch name starts with
deploybut also when it ismainAdditionally add logic to check if the rsconnect json file was updated to ensure that the deploy did take place. Currently we check if the file has been modified in the past 10 mins, on average the tests take 7 mins to run