Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): Playwright test refactors and clean up #1204

Merged
merged 6 commits into from
Mar 23, 2024
Merged

chore(test): Playwright test refactors and clean up #1204

merged 6 commits into from
Mar 23, 2024

Conversation

joesho112358
Copy link
Contributor

  • remove unused code in input switch test
  • consolidate imports to the top in the sidebar tests
  • refactor and use the parameterization in the valuebox tests

schloerke
schloerke approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@schloerke
Merge branch 'main' into sidebar-valuebox-tests
13d123b 
* main: (24 commits)
  chore: Disable broken test on CI; Fix broken docs entries (posit-dev#1241)
  Add back missing session methods (posit-dev#1239)
  Add kitchensink tests for valuebox (posit-dev#1229)
  For Express, emit message if need to upgrade rsconnect-python (posit-dev#1233)
  feat: Editable data frame (posit-dev#1198)
  Add tests for shiny_mode comment detection
  fix(input_dark_mode): Allow users to customize `style` attribute (posit-dev#1207)
  chore(get_current_session): Return default session if current is explicitly None (posit-dev#1086)
  chore: use dev htmtlools (posit-dev#1228)
  feat(layout_columns): Use `sm` as the default `col_widths` breakpoint (posit-dev#1222)
  feat: ensure min/max height args on `value_box()` and column layouts (posit-dev#1223)
  fix(static_assets): Need the directory containing the `app.py`, not the file itself (posit-dev#1219)
  Update bslib and shiny dependencies (posit-dev#1221)
  Update docstring and give hint for mypy
  Add support for Shiny Express in Quarto Dashboards, take 2 (posit-dev#1217)
  Force UTF-8 for Shiny Express on Windows (posit-dev#1203)
  Typing fixes
  feat(card): Report full screen state as a Shiny input (posit-dev#1215)
  Use TypeScript strict mode (posit-dev#1208)
  Update author email
  ...
@schloerke
Comment broken test
4e7cd16
@schloerke schloerke changed the title Playwright test refactors and clean up chore(test): Playwright test refactors and clean up Mar 23, 2024
@schloerke schloerke merged commit ea1fa2c into posit-dev:main Mar 23, 2024
32 checks passed
schloerke added a commit that referenced this pull request Mar 28, 2024
@schloerke
Merge branch 'main' into build_tools_uv
c3c2120 
* main:
  test(CI): Add merge queue support for faster PR testing (#1265)
  fix(panel_conditional): Include `.shiny-panel-conditional` class (#1257)
  feat: Create `Session.set_message_handler(name, handler)` (#1253)
  Fix input name
  Enable error console when running locally. (#1060)
  test: Update test to use variable, not capture stdout (#1236)
  test: Fix deploys for shinyapps.io and connect (#1224)
  chore(test): Playwright test refactors and clean up (#1204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joesho112358 @schloerke