Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking #4532

Merged
merged 1 commit into from
May 1, 2024
Merged

Release tracking #4532

merged 1 commit into from
May 1, 2024

Conversation

primer[bot]
Copy link
Contributor

@primer primer bot commented Apr 24, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/react@36.17.0

Minor Changes

Patch Changes

Copy link
Contributor

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass on this pull request
  • Docs and Storybook open in a browser
  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🌏 Integration tests

  • Successful integration test with github/github as a primary consumer of Primer React (automated pull request)
    • Verify all CI checks have passed on automated pull request
    • Manually test critical paths in the review-lab
    • Manually test release-specific bugfixes and/or features work as described in the review-lab

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • The issues for reverted PRs have been re-opened and commented on with a link to the reverted PR
  • No noticeable regressions have not been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

🚢 After merge

  • Upgrade @primer/react version at github/github

  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Please also leave any testing notes on the weekly release tracking issue. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to the next release conductor as well as maintainers.

Copy link
Contributor

github-actions bot commented Apr 24, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 87.98 KB (0%)
packages/react/dist/browser.umd.js 88.28 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4532 April 24, 2024 14:18 Inactive
@primer primer bot force-pushed the changeset-release/main branch from e2b7b8a to 16e063d Compare April 24, 2024 15:06
@primer primer bot requested a review from a team as a code owner April 24, 2024 15:06
@github-actions github-actions bot temporarily deployed to storybook-preview-4532 April 24, 2024 15:13 Inactive
@primer primer bot force-pushed the changeset-release/main branch from 16e063d to a634ee6 Compare April 24, 2024 16:40
@github-actions github-actions bot temporarily deployed to storybook-preview-4532 April 24, 2024 16:44 Inactive
@primer primer bot force-pushed the changeset-release/main branch from a634ee6 to 64ac129 Compare April 25, 2024 14:59
@github-actions github-actions bot temporarily deployed to storybook-preview-4532 April 25, 2024 15:03 Inactive
@pksjce
Copy link
Collaborator

pksjce commented Apr 30, 2024

We have integration tests passing for this release 🥳
https://github.com/github/github/pull/323061

@pksjce
Copy link
Collaborator

pksjce commented Apr 30, 2024

Review lab looks sane 🎆

@pksjce pksjce added this pull request to the merge queue Apr 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024
@pksjce pksjce added this pull request to the merge queue Apr 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024
@pksjce
Copy link
Collaborator

pksjce commented May 1, 2024

The merge queue seems to be spitting out this PR for some playwright test failures particularly in some themes of ActionList tests.
Ran these on local and it fails there too. I'm unable to determine whats the change that its complaining about. Is it the avatar because it has red dots on it in the diff image.
Here is an example
Actual:
ActionList-Block-Description-dark-dimmed-actual

Expected:
ActionList-Block-Description-dark-dimmed-expected

Diff:
ActionList-Block-Description-dark-dimmed-diff

@pksjce pksjce added this pull request to the merge queue May 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2024
@siddharthkp siddharthkp added this pull request to the merge queue May 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 1, 2024
@primer primer bot requested a review from a team as a code owner May 1, 2024 12:21
@primer primer bot requested a review from tbenning May 1, 2024 12:21
@github-actions github-actions bot requested a review from pksjce May 1, 2024 12:22
@primer primer bot temporarily deployed to github-pages May 1, 2024 12:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4532 May 1, 2024 12:25 Inactive
@pksjce pksjce enabled auto-merge May 1, 2024 12:31
@primer primer bot force-pushed the changeset-release/main branch from 1117b93 to 42846c1 Compare May 1, 2024 17:45
@github-actions github-actions bot requested a review from pksjce May 1, 2024 17:47
@pksjce pksjce added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 9018b32 May 1, 2024
31 checks passed
@pksjce pksjce deleted the changeset-release/main branch May 1, 2024 18:04
lukasoppermann pushed a commit that referenced this pull request May 3, 2024
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants