VRT: Mock avatars to return stable images #4547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
siddharthkp
changed the title
size-limit report 📦
|
joshblack
approved these changes
May 1, 2024
siddharthkp
requested review from
langermank
and removed request for
maximedegreve
This comment was marked as resolved.
This comment was marked as resolved.
langermank
approved these changes
May 1, 2024
lukasoppermann
pushed a commit
that referenced
this pull request
May 3, 2024
* just trying something out * should come sooner * test(vrt): update snapshots --------- Co-authored-by: siddharthkp <siddharthkp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
To make our stories realistic and useful, we use examples of real collaborations in our stories (instead of fake or generated data). This is very nice!
This also means when one of the collaborators updates their avatar, some of stories also update. This is also very nice!
But, this also means that our visual tests can fail because they have the old avatar in snapshots to compare. This is not nice at all! 😓 Most recently reported in #4532 (comment)
Solution:
Added a route mock for our e2e tests (visual tests) that always returns the same image that is safe for visual comparisons. Chose the primer avatar for this. (could have also used a static image, but this feels as good)
Alternatives considered:
Rollout strategy
Merge checklist