Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++14 issues #1

Closed
flannelhead opened this issue Nov 1, 2016 · 6 comments
Closed

C++14 issues #1

flannelhead opened this issue Nov 1, 2016 · 6 comments

Comments

@flannelhead
Copy link
Contributor

flannelhead commented Nov 1, 2016

Compiling from master @ 36f51ff yields quite a many compilation errors with a recent gcc (version 6.2.1) on Linux due to errors in code in #ifdef SLIC3R_CPP > 11 blocks. The default C++ standard for recent gcc is C++14 (more precisely -std=gnu++14 which contains GNU extensions). The errors are especially related to rvalue reference overloaded functions in e.g. PolylineCollection.cpp (chained_path and chained_path_from).

Are you accepting contributions to your fork? I might start slowly looking at these in order to make it build on more recent compilers and take advantage of the move semantics.

@flannelhead
Copy link
Contributor Author

Also, I should mention that the code builds fine with the same compiler with the -std=c++11 flag. So there are definitely faults in the C++14 specific code.

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 1, 2016

Thank you. I am developing mainly on Visual Studio 2013 and the builds are built on Strawberry Perl and on MacOS, where the C++14 features are disabled. I shall disable the C++14 optimizations for now, before the issues get cleared.

@bubnikv
Copy link
Collaborator

bubnikv commented Nov 1, 2016

Are you accepting contributions to your fork? I might start slowly looking at these in order to make it build on more recent compilers and take advantage of the move semantics.

Yes, please, we will be thankful for pull requests.

@flannelhead
Copy link
Contributor Author

@bubnikv Alright, I shall create a PR where I incrementally add the fixes. At least I'll be able to fix the most evident mistakes, but the other stuff might take some time. I'll close this issue for now.

@flannelhead
Copy link
Contributor Author

Reopening to make this better discoverable by those having similar problems.

@flannelhead flannelhead reopened this Nov 1, 2016
@flannelhead
Copy link
Contributor Author

@bubnikv I assume this can be closed now as #10 got merged.

CReimer pushed a commit to CReimer/Slic3r that referenced this issue Jul 28, 2017
…ts-logic

Added test for enforced support generation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants