Allow module to work on SLES #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, if you set acknowledge_unsupported_os = true you'd still fail on SLES 12 because the docker::run define doesn't know that SLES uses systemd and drops down to failing After this commit, we copy the default section in params for suse and set the service_provider to systemd so the run define will work. The user still needs to manually install docker on SLES 12 but this allows managing the service etc... to work.
|
Merging without further tests or support to accommodate the use on unsupported SLES. |
barriserloth
added a commit
to barriserloth/puppetlabs-docker
that referenced
this pull request
Sep 26, 2023
This commit adds to the list of officially supported platform. My rationale for adding Centos/RHEL 8 is because of this change: puppetlabs#926 My rationale for adding SLES is because of this change: puppetlabs#591 And I've also added Alma, Amazon, Oracle, Rocky and Scientific to the list as well since they are all RedHat derivatives and would ideally be supported alongside RHEL.
5 tasks
barriserloth
added a commit
to barriserloth/puppetlabs-docker
that referenced
this pull request
Sep 26, 2023
This commit adds to the list of officially supported platform. My rationale for adding Centos/RHEL 8 is because of this change: puppetlabs#926 My rationale for adding SLES is because of this change: puppetlabs#591 And I've also added Alma, Amazon, Oracle, Rocky and Scientific to the list as well since they are all RedHat derivatives and would ideally be supported alongside RHEL.
barriserloth
added a commit
to barriserloth/puppetlabs-docker
that referenced
this pull request
Oct 30, 2023
This commit adds to the list of officially supported platform. My rationale for adding Centos/RHEL 8 is because of this change: puppetlabs#926 My rationale for adding SLES is because of this change: puppetlabs#591 And I've also added Alma, Oracle, Rocky and Scientific to the list as well since they are all RedHat derivatives and would ideally be supported alongside RHEL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if you set acknowledge_unsupported_os = true
you'd still fail on SLES 12 because the docker::run define
doesn't know that SLES uses systemd and drops down to failing
After this commit, we copy the default section in params for
suse and set the service_provider to systemd so the run define
will work.
The user still needs to manually install docker on SLES 12 but this
allows managing the service etc... to work.