(maint) Add to supported platform list #953
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barriserloth
force-pushed
the
maint/main/add-supported-os
branch
from
f8101ef
to
1c73f89
Compare
This commit adds to the list of officially supported platform. My rationale for adding Centos/RHEL 8 is because of this change: puppetlabs#926 My rationale for adding SLES is because of this change: puppetlabs#591 And I've also added Alma, Oracle, Rocky and Scientific to the list as well since they are all RedHat derivatives and would ideally be supported alongside RHEL.
barriserloth
force-pushed
the
maint/main/add-supported-os
branch
from
1c73f89
to
41462a8
Compare
|
Is it possible that RHEL8 was excluded from earlier addition as Docker is not the supported container runtime for RHEL 8 & 9, plus documentation for Docker engine https://docs.docker.com/engine/install/ lists no support for RHEL apart from RHEL (s390x) which is not a supported puppet agent platform |
|
This section of the readme should just point the reader to metadata.json, since that's what actually matters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds to the list of officially supported platform. My rationale for adding Centos/RHEL 8 is because of this change: #926 My rationale for adding SLES is because of this change: #591
And I've also added Alma, Oracle, Rocky and Scientific to the list as well since they are all RedHat derivatives and would ideally be supported alongside RHEL.
Summary
Provide a detailed description of all the changes present in this pull request.
See commit message above
Please let me know if there are any issues with this, and I'm happy to amend my changes. Thanks!
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)