Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTree should not be "Generic" #9445

Merged
merged 3 commits into from
Sep 8, 2024
Merged

DataTree should not be "Generic" #9445

merged 3 commits into from
Sep 8, 2024

Commits on Sep 7, 2024

  1. DataTree should not be "Generic" 

    DataTree isn't a Generic tree type. It's a specific tree type -- the
nodes are DataTree objects.

This was resulting in many cases where mypy insisting on explicit type
annotations, e.g., `tree: DataTree = DataTree(...)`, which is
unnecessary and annoying boilerplate.
    @shoyer
    shoyer committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    560a038 View commit details
    Browse the repository at this point in the history

  2. Fix type error

    @shoyer
    shoyer committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    aff87f0 View commit details
    Browse the repository at this point in the history

  3. type ignore

    @shoyer
    shoyer committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    24bdc11 View commit details
    Browse the repository at this point in the history