Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Add menu bar #263

Merged
merged 10 commits into from
May 17, 2021
Merged

[Windows] Add menu bar #263

merged 10 commits into from
May 17, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented May 1, 2021 •
edited
Loading

Description

  • Added menu bar
  • Removed status bar (now matches macOS; may reintroduce later if I find a good use for it)
  • Cleaned up a bunch of control names

image
image
image

To be filled out later:

  • Recent files menu (revert BetterComboBox)
  • Implement options dialog, where one can configure flashing tool locations & arguments etc.
  • Keytester under Tools menu (Add Keytester to QMK Toolbox #41)
  • USB device log under Tools menu (all devices, not just Console-enabled and bootloaders)
  • Move Console stuff into separate dialog to avoid confusion?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

@fauxpark fauxpark requested a review from a team May 1, 2021 09:53
@fauxpark fauxpark mentioned this pull request May 5, 2021
Merged
5 tasks
@fauxpark fauxpark merged commit 702540a into qmk:master May 17, 2021
@fauxpark fauxpark deleted the windows-menubar branch May 17, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nooges nooges nooges approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
enhancement windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @nooges @tzarc