Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Add menu bar #264

Merged
merged 1 commit into from
May 17, 2021
Merged

[macOS] Add menu bar #264

merged 1 commit into from
May 17, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented May 5, 2021

Description

The macOS end of #263.

image

  • Added back some of the default menus
  • Disabled tabbing
  • Set minimum window size to 800x640 as in Windows; also now opens in center screen
  • Made the titlebar transparent cause I thought it looked nice.

Will try to fix the constraint warnings in a followup PR.

The "Check for Updates" menu items here are disabled for now as I plan to implement Sparkle/WinSparkle, but it requires setting up the Xcode project to use Pods first, and setting up an update feed somewhere.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

@fauxpark fauxpark requested a review from a team May 5, 2021 14:34
@fauxpark fauxpark merged commit 8fc78f1 into qmk:master May 17, 2021
@fauxpark fauxpark deleted the macos-menubar branch May 17, 2021 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants