feat(save): support custom timestamps on commit #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting the input dataset commit.Timestamp value will now be preserved instead of being overwritten with the current time. Input timestamp will ALWAYS be converted to UTC time zone. This change makes it much easier to generate dataset histories with commit timestamps that aren't in chronological order, which is perfectly fine according to spec, but will cause bugs for any code that relies on such an assumption.
dustmop
approved these changes
Dec 7, 2020
lib/peers.json
Outdated
| @@ -0,0 +1 @@ | |||
| {"QmeL2mdVka1eahKENjehK6tBxkkpk5dNQ1qMcgWi7Hrb4B":{"id":"QmeL2mdVka1eahKENjehK6tBxkkpk5dNQ1qMcgWi7Hrb4B","peername":"default_profile_for_testing","created":"2020-12-07T09:41:29.273167-05:00","updated":"2020-12-07T09:41:29.273167-05:00","type":"peer","email":"","name":"","description":"","homeurl":"","color":"","thumb":"","photo":"","poster":"","twitter":""}} | |||
There was a problem hiding this comment.
Remove this file, and peers.json.lock as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let qri-git match timestamps from git on import.
setting the input dataset commit.Timestamp value will now be preserved instead of being overwritten with the current time. Input timestamp will ALWAYS be converted to UTC time zone.
This change makes it much easier to generate dataset histories with commit timestamps that aren't in chronological order, which is perfectly fine according to spec, but will cause bugs for any code that relies on such an assumption.