Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(save): support custom timestamps on commit #1594

Merged
merged 2 commits into from
Dec 7, 2020
Merged

feat(save): support custom timestamps on commit #1594

merged 2 commits into from
Dec 7, 2020

Commits on Dec 7, 2020

  1. feat(save): support custom timestamps on commit 

    setting the input dataset commit.Timestamp value will now be preserved instead
of being overwritten with the current time. Input timestamp will ALWAYS be
converted to UTC time zone.

This change makes it much easier to generate dataset histories with commit
timestamps that aren't in chronological order, which is perfectly fine
according to spec, but will cause bugs for any code that relies on such an
assumption.
    @b5
    b5 committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    e8c18fa View commit details
    Browse the repository at this point in the history

  2. test(save): don't provide timestamps to save

    @b5
    b5 committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    31ef365 View commit details
    Browse the repository at this point in the history