QA: Week July 29th

[davidkircos]

Merge pull request #1597 from quadratichq/qa

Bugs in this release:

• qa: bug when clicking on code cells #1658
• qa: Multiline Formula Bugs #1657
• Scientific + currency formatting bug
• Blocking bugs on QAWolf

After these we will just focus on bugs and shipping this PR.

Blocking issues:

• Currency and scientific formatting not working  #1633
• QA branch not syncing large files, perpetually "reconnecting"
• Create new file does not work fix create new file on qa branch #1641
• QA Wolf test file import fails fix: import QAWolf test file #1643
• Code results, API requests etc not rendering correctly fix: text displays as NaN for code result #1642
• Drag to duplicate code cells not working perf: improve performance of auto row resize when wrapping large dataset #1634
• Rerun all code fails in QA Wolf test file perf: improve performance of auto row resize when wrapping large dataset #1634
• Wrapping and auto resize performance is not good, memory leak happens when scrolling in a large sheet perf: improve performance of auto row resize when wrapping large dataset #1634
• Formula suggestions not populating fix: execute keyboard events only when suggestion widget is hidden #1599 (comment)

[qa-wolf]

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
quadratic	✅ Ready (Inspect)	Visit Preview	Aug 8, 2024 9:54pm

[codecov]

Codecov Report

Attention: Patch coverage is 96.95463% with 49 lines in your changes missing coverage. Please review.

Project coverage is 90.61%. Comparing base (116af6d) to head (842c620).
Report is 71 commits behind head on main.

Files	Patch %	Lines
...rc/controller/execution/auto_resize_row_heights.rs	98.63%	9 Missing ⚠️
...ler/execution/execute_operation/execute_formats.rs	82.05%	7 Missing ⚠️
...dratic-core/src/controller/operations/operation.rs	0.00%	7 Missing ⚠️
...ler/execution/execute_operation/execute_offsets.rs	94.28%	6 Missing ⚠️
...tic-core/src/controller/active_transactions/mod.rs	84.00%	4 Missing ⚠️
...ratic-core/src/controller/operations/formatting.rs	75.00%	4 Missing ⚠️
quadratic-core/src/compression.rs	98.11%	2 Missing ⚠️
...atic-core/src/controller/execution/run_code/mod.rs	91.66%	2 Missing ⚠️
quadratic-core/src/controller/send_render.rs	89.47%	2 Missing ⚠️
...re/src/controller/execution/control_transaction.rs	96.87%	1 Missing ⚠️
... and 5 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1617      +/-   ##
==========================================
+ Coverage   89.94%   90.61%   +0.66%     
==========================================
  Files         185      192       +7     
  Lines       35022    38188    +3166     
==========================================
+ Hits        31500    34603    +3103     
- Misses       3522     3585      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[luke-quadratic]

👍